hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 05:51:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update button style logic in Confirming page based on selection state

Browse source 
- Modified the button style in the Confirming page to dynamically switch between "Primary" and "Neutral" based on whether all items are selected, enhancing visual feedback for users.

This change aims to improve user experience by providing clearer indications of the current selection state.
This commit is contained in:
Joe 2026-03-01 07:00:46 -06:00
parent cd87c63a89
commit b8bd92d665
2 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
TODO.txt
View file

@ -342,6 +342,3 @@ I notice we actually use the git cli in a lot of places. is there a git library
[auto select studio/atlas] [auto select studio/atlas]
when things get added AFTER the fact because we send the git history hashes on connect rather than continiously, it auto-selects Studio for things that are being edited in real-time in the sync dialog when things get added AFTER the fact because we send the git history hashes on connect rather than continiously, it auto-selects Studio for things that are being edited in real-time in the sync dialog
how should we handle new files? because it could have been that someone just deleted it in studio. we can actually check if its a truly new file in Studio, like A but not staged! how should we handle new files? because it could have been that someone just deleted it in studio. we can actually check if its a truly new file in Studio, like A but not staged!
[merge visualizer]
we should make the outline green or something to show when everything is ready to go. maybe the accept button

2
plugin/src/App/StatusPages/Confirming.lua
View file

@ -366,7 +366,7 @@ function ConfirmingPage:render()
Accept = e(TextButton, { Accept = e(TextButton, {
text = if hasChanges then "Accept" else "OK", text = if hasChanges then "Accept" else "OK",
style = "Primary", style = if allSelected then "Primary" else "Neutral",
transparency = self.props.transparency, transparency = self.props.transparency,
layoutOrder = 2, layoutOrder = 2,
onClick = function() onClick = function()