From b8bd92d665d6437abc59d872534ddce0b0d4790c Mon Sep 17 00:00:00 2001 From: Joe Date: Sun, 1 Mar 2026 07:00:46 -0600 Subject: [PATCH] Update button style logic in Confirming page based on selection state - Modified the button style in the Confirming page to dynamically switch between "Primary" and "Neutral" based on whether all items are selected, enhancing visual feedback for users. This change aims to improve user experience by providing clearer indications of the current selection state. --- TODO.txt | 3 --- plugin/src/App/StatusPages/Confirming.lua | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/TODO.txt b/TODO.txt index 10b17757..1ac45c66 100644 --- a/TODO.txt +++ b/TODO.txt @@ -342,6 +342,3 @@ I notice we actually use the git cli in a lot of places. is there a git library [auto select studio/atlas] when things get added AFTER the fact because we send the git history hashes on connect rather than continiously, it auto-selects Studio for things that are being edited in real-time in the sync dialog how should we handle new files? because it could have been that someone just deleted it in studio. we can actually check if its a truly new file in Studio, like A but not staged! - -[merge visualizer] -we should make the outline green or something to show when everything is ready to go. maybe the accept button diff --git a/plugin/src/App/StatusPages/Confirming.lua b/plugin/src/App/StatusPages/Confirming.lua index 9db24a2f..b4e7f383 100644 --- a/plugin/src/App/StatusPages/Confirming.lua +++ b/plugin/src/App/StatusPages/Confirming.lua @@ -366,7 +366,7 @@ function ConfirmingPage:render() Accept = e(TextButton, { text = if hasChanges then "Accept" else "OK", - style = "Primary", + style = if allSelected then "Primary" else "Neutral", transparency = self.props.transparency, layoutOrder = 2, onClick = function()