mirror of
https://github.com/centau/vide.git
synced 2026-08-20 14:41:37 +00:00
Auto strict mode based on optimization level
This commit is contained in:
parent
8b4210e66a
commit
cc4b390d3d
5 changed files with 31 additions and 28 deletions
|
|
@ -1 +1,7 @@
|
|||
return { strict = false }
|
||||
local function inline_test(): string
|
||||
return debug.info(1, "n")
|
||||
end
|
||||
|
||||
local is_O2 = inline_test() ~= "inline_test"
|
||||
|
||||
return { strict = not is_O2 }
|
||||
|
|
|
|||
|
|
@ -91,28 +91,22 @@ local vide = {
|
|||
end
|
||||
}
|
||||
|
||||
do
|
||||
local set = false
|
||||
|
||||
setmetatable(vide :: any, {
|
||||
__index = function(_, index: unknown): ()
|
||||
if index == "strict" then
|
||||
return flags.strict
|
||||
else
|
||||
throw(`{tostring(index)} is not a valid member of vide`)
|
||||
end
|
||||
end,
|
||||
|
||||
__newindex = function(_, index: unknown, value: unknown)
|
||||
if index == "strict" then
|
||||
if set then throw "strict mode has already been set" end
|
||||
set = true
|
||||
flags.strict = value :: boolean
|
||||
else
|
||||
throw(`{tostring(index)} is not a valid member of vide`)
|
||||
end
|
||||
setmetatable(vide :: any, {
|
||||
__index = function(_, index: unknown): ()
|
||||
if index == "strict" then
|
||||
return flags.strict
|
||||
else
|
||||
throw(`{tostring(index)} is not a valid member of vide`)
|
||||
end
|
||||
})
|
||||
end
|
||||
end,
|
||||
|
||||
__newindex = function(_, index: unknown, value: unknown)
|
||||
if index == "strict" then
|
||||
flags.strict = value :: boolean
|
||||
else
|
||||
throw(`{tostring(index)} is not a valid member of vide`)
|
||||
end
|
||||
end
|
||||
})
|
||||
|
||||
return vide
|
||||
|
|
|
|||
|
|
@ -9,6 +9,8 @@ local values = vide.values
|
|||
local cleanup = vide.cleanup
|
||||
local create = vide.create
|
||||
|
||||
assert(not vide.strict)
|
||||
|
||||
local function TITLE(name: string)
|
||||
print()
|
||||
print(testkit.color.white(name))
|
||||
|
|
|
|||
|
|
@ -31,6 +31,8 @@ end
|
|||
|
||||
local NIL = nil :: any
|
||||
|
||||
vide.strict = false
|
||||
|
||||
TEST("graph", function()
|
||||
local create_node = graph.create_node
|
||||
local track = graph.track
|
||||
|
|
@ -1644,6 +1646,8 @@ TEST("changed()", wrap_root(function()
|
|||
end
|
||||
end))
|
||||
|
||||
vide.strict = true
|
||||
|
||||
TEST("strict", wrap_root(function()
|
||||
vide.strict = true
|
||||
|
||||
|
|
|
|||
7
todo.md
7
todo.md
|
|
@ -1,16 +1,13 @@
|
|||
# todo
|
||||
|
||||
- auto-enable of strict mode depending on compiler optimizaton level
|
||||
- property binding optimization
|
||||
- would no longer allow `cleanup()` usage in binding scopes
|
||||
- solution to nested reactivity, see: SolidJS stores
|
||||
- investigate performance of wide graphs
|
||||
- optimize child removal
|
||||
- optimize wide graph updating
|
||||
- implement from solid:
|
||||
- Portal
|
||||
- batch
|
||||
- optimize `indexes()` double-diffing
|
||||
- define behavior of deriving a source within a derived source
|
||||
- review destruction of node under a root that has a child in another root
|
||||
- check in strict mode for forgetting to call constructor `create(class)`
|
||||
- define behavior of node destruction under a root that has a child in another root
|
||||
- improve crash course, some sections feel like information dumps
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue