hakowork/vide
3
0
Fork 0
mirror of https://github.com/centau/vide.git synced 2026-10-23 14:14:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix children being unparented after moving to another parent (#102)

Browse source 
Co-authored-by: centau <83140718+centau@users.noreply.github.com>
This commit is contained in:
Kaan 2026-10-22 14:38:05 +03:00 • committed by GitHub
parent c2bd2c2d4c
commit a75e3ee843
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 30 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/implicit_effect.luau
View file

@ -62,7 +62,7 @@ local function update_children_effect(p: {
push_cleanup(assert(get_scope()), function()
for child in node.cache.cur_children_set do
child.Parent = nil
if child.Parent == p.instance then child.Parent = nil end
end
end)
end
@ -71,7 +71,7 @@ local function update_children_effect(p: {
process_child(new_children)
for child in cur_children_set do
child.Parent = nil -- unparent all children that weren't in the new children set
if child.Parent == p.instance then child.Parent = nil end -- unparent all children that weren't in the new children set
end
table.clear(cur_children_set) -- clear cache, preserve capacity
@ -116,7 +116,7 @@ return {
push_cleanup(assert_stable_scope(), function()
for child in node.cache.cur_children_set do
child.Parent = nil
if child.Parent == instance then child.Parent = nil end
end
end)