.luaurc

@@ -1,6 +1,6 @@
 {
     "languageMode": "strict",
     "lint": { "BuiltinGlobalWrite": false, "UnknownGlobal": false },
-    "globals": []
+    "globals": [ "Instance" ]
 }
 

src/Children.lua

@@ -1,39 +0,0 @@
-------------------------------------------------------------------------------------------
--- vide/Children.lua
-------------------------------------------------------------------------------------------
-
-if not game then
-    script = (require :: any) "test/wrap-require"
-    typeof = require "test/mock".typeof
-end
-
-local graph = require(script.Parent.graph)
-local wrapped = graph.wrapped
-
-local throw = require(script.Parent.throw)
-local bind = require(script.Parent.bind)
-local Types = require(script.Parent.Types)
-
-type Children = Types.Children
-
-local function setChildren(instance: Instance, children: Children)
-    if typeof(children) == "Instance" then
-        if children.Parent then throw(`Cannot parent instance { instance.Name }, instance already parented`) end
-        children.Parent = instance
-    elseif wrapped(children) then
-        bind.children(children :: any, instance )
-    elseif type(children) == "table" then
-        for _, child: Children in next, children do
-            setChildren(instance, child)
-        end
-    else
-        throw(`Cannot parent non-instance { typeof(children) }`)
-    end
-end
-
-local Children = {
-    priority = 1,
-    run = setChildren
-} :: Types.Symbol<Children>
-
-return Children :: unknown

src/Created.lua

@@ -1,16 +0,0 @@
-------------------------------------------------------------------------------------------
--- vide/Created.lua
-------------------------------------------------------------------------------------------
-
-if not game then script = (require :: any) "test/wrap-require" end
-
-local Types = require(script.Parent.Types)
-
-local Created = {
-    priority = 3,
-    run = function(instance: Instance, callback: (Instance) -> ())
-        callback(instance)
-    end
-} :: Types.Symbol<(Instance) -> ()>
-
-return Created :: unknown

src/Layout.lua

@@ -1,46 +0,0 @@
-------------------------------------------------------------------------------------------
--- vide/Layout.lua
-------------------------------------------------------------------------------------------
-
-if not game then script = (require :: any) "test/wrap-require" end
-
-local graph = require(script.Parent.graph)
-local wrapped = graph.wrapped
-
-local throw = require(script.Parent.throw)
-local bind = require(script.Parent.bind)
-local flags = require(script.Parent.flags)
-local Types = require(script.Parent.Types)
-
-local layoutProperties = {
-    Parent = true,
-    AnchorPoint = true,
-    LayoutOrder = true,
-    Position = true,
-    Rotation = true,
-    Size = true,
-    SizeConstraint = true,
-    Visible = true,
-    ZIndex = true
-}
-
-local function setLayout(instance: Instance, properties: { [string]: unknown })
-    for property, value in next, properties do
-        if flags.strict and not layoutProperties[property] then
-            throw(`{ property } is not a valid layout property`)
-        end
-
-        if wrapped(value) then
-            bind.property(value :: graph.State<unknown>, instance, property)
-        else
-            (instance :: any)[property] = value
-        end
-    end
-end
-
-local Layout = {
-    priority = 1,
-    run = setLayout
-} :: Types.Symbol<{ [string]: unknown }>
-
-return Layout :: unknown

src/Types.lua

@@ -1,19 +0,0 @@
---------------------------------------------------------------------------------------------------------------
--- vide/Types.lua
---------------------------------------------------------------------------------------------------------------
-
-if not game then script = (require :: any) "test/wrap-require" end
-
-local graph = require(script.Parent.graph)
-
-type State<T> = graph.State<T>
-type MaybeState<T> = graph.MaybeState<T>
-
-export type Symbol<T> = {
-    priority: number,
-    run: (Instance, T) -> ()
-}
-
-export type Children = Instance | State<Children> | { Children }
-
-return {}

src/each.lua

@@ -1,24 +0,0 @@
---------------------------------------------------------------------------------------------------------------
--- vide/each.lua
---------------------------------------------------------------------------------------------------------------
-
-if not game then script = (require :: any) "test/wrap-require" end
-
-local graph = require(script.Parent.graph)
-type State<T> = graph.State<T>
-type Node<T> = graph.Node<T>
-local create = graph.create
-local get = graph.get
-local wrapped = graph.wrapped
-local link = graph.link
-
-type Map<K, V> = { [K]: V }
-
-local function each<K, VI, VO>(input: State<Map<K, VI>>, transform: (K, VI) -> VO, cleanup: (VO) -> ()?)
-    
-end
-
-return (each :: any) ::  ( <V>(input: number, transform: (number) -> V) -> Map<number, V> ) &
-                        ( <K, VI, VO>(input: Map<K, VI>, transform: (K, VI) -> VO) -> Map<K, VO> ) &
-                        ( <K, VI, VO>(input: State<Map<K, VI>>, transform: (K, VI) -> VO, cleanup: (VO) -> ()?)
-                            -> State<Map<K, VO>> )

src/graph.lua

@@ -19,13 +19,13 @@ local refs = {} :: { Node<unknown> }
 local WEAK_VALUES_RESIZABLE = { __mode = "vs" }
 local EVALUATION_ERR = "error while evaluating node:\n\n"
 
-setmetatable(refs, WEAK_VALUES_RESIZABLE)
+setmetatable(refs :: any, WEAK_VALUES_RESIZABLE)
 
 local check_for_yield do
     local t = { __mode = "kv" }
     setmetatable(t, t)
 
-    check_for_yield = function<T..., U...>(fn: (T...) -> (), ...: U...)
+    check_for_yield = function<T..., U...>(fn: (T...) -> (), ...: any)
         local args = { ... }
         t.__unm = function()
             fn(unpack(args))
@@ -96,13 +96,19 @@ local function link<T>(parent: Node<unknown>, child: Node<T>, derive: () -> T)
 end
 
 -- detect what nodes were referenced in the given callback and returns them in an array
-local function capture<T, U>(fn: (U) -> T, arg: U): ({ Node<unknown> }, T)
+local function capture<T, U>(fn: (U?) -> T, arg: U?): ({ Node<unknown> }, T)
     if flags.strict then check_for_yield(fn, arg) end
 
     table.clear(refs)
     reff = true
 
-    local ok: boolean, result: T|string = pcall(fn, arg)
+    local ok: boolean, result: T|string
+    
+    if arg == nil then
+        ok, result = pcall(fn)
+    else
+        ok, result = pcall(fn, arg)
+    end
 
     reff = false
 
@@ -123,13 +129,19 @@ local function capture_and_link<T>(child: Node<T>, fn: () -> T): T
     return value :: T
 end
 
-local function create<T>(value: T): Node<T>
-    return {
+local function create<T>(value: T): (Node<T>, () -> T)
+    local node = {
         cache = value,
         derive  = function() return nil :: any end,
         effects = setmetatable({}, WEAK_VALUES_RESIZABLE) :: any,
         children = false :: false
     }
+
+    local function get_value()
+        return get(node)
+    end
+
+    return node, get_value
 end
 
 return table.freeze {
@@ -139,5 +151,5 @@ return table.freeze {
     link = link,
     capture = capture,
     capture_and_link = capture_and_link,
-    create = create,
+    create = create :: (<T>(value: T) -> (Node<T>, () -> T)) & (<T>() -> (Node<T>, () -> T)),
 }

src/map.lua

@@ -5,72 +5,66 @@
 if not game then script = (require :: any) "test/wrap-require" end
 
 local graph = require(script.Parent.graph)
-type State<T> = graph.State<T>
-type MaybeState<T> = graph.MaybeState<T>
+type Node<T> = graph.Node<T>
 local create = graph.create
-local get = graph.get
-local wrapped = graph.wrapped
+local set = graph.set
+local capture = graph.capture
 local link = graph.link
+local capture_and_link = graph.capture_and_link
 
 type Map<K, V> = { [K]: V }
 
-local function map<K, VI, VO>(input: unknown, transform: (K, VI) -> VO, cleanup: (VO) -> ()?): (MaybeState<Map<K, VO>>)
-    if type(input) == "number" then
-        local output: Map<K, VO> = table.create(input) :: {}
+local function map<K, VI, VO>(input: () -> Map<K, VI>, transform: (() -> VI, K) -> VO): () -> Map<K, VO>
+    local input_cache = {} :: Map<K, VI>
+    local output_cache = {} :: Map<K, VO>
+    local input_nodes = {} :: Map<K, Node<VI>>
+    local remove_queue = {} :: { K }
 
-        for i = 1, input do
-            local v = transform(i :: any, nil :: any)
-            output[i :: any] = v
-        end
-
-        return output
-    elseif wrapped(input) then
-        local lastInput: Map<K, VI> = {}
-        local lastOutput: Map<K, VO> = {}
-        local output = create(lastOutput)
-
-        local function derive()
-            local newInput = get(input :: State<Map<K, VI>>)
-            if type(newInput) ~= "table" then error("Attempt to run map on a non-table state", 0) end
-
-            local lastInputClone = table.clone(lastInput)
-
-            for k, vi in next, newInput do
-                if vi ~= lastInputClone[k] then
-                    local vo = transform(k, vi)
-                    if cleanup and lastOutput[k] then cleanup(lastOutput[k]) end
-                    lastInput[k] = vi
-                    lastOutput[k] = vo
-                end
-                lastInputClone[k] = nil
+    local function recompute(data)
+        -- queue removed values
+        for k in next, input_cache do
+            if data[k] == nil then
+                table.insert(remove_queue, k)
             end
+        end
 
-            for k, v in next, lastInputClone do
-                lastInput[k] = nil
-                if cleanup and lastOutput[k] then cleanup(lastOutput[k]) end   
-                lastOutput[k] = nil
+        -- remove queued values
+        for _, k in next, remove_queue do
+            input_cache[k] = nil
+            output_cache[k] = nil
+            input_nodes[k] = nil
+        end
+
+        -- process new or changed values
+        for k, v in next, data do
+            if input_cache[k] == nil then
+                local node, get_value = create(v)
+                input_nodes[k] = node
+                output_cache[k] = transform(get_value, k)
+            elseif input_cache[k] ~= v then
+                set(input_nodes[k], v)
             end
-
-            return table.clone(lastOutput)
+            input_cache[k] = v
         end
 
-        link(input :: State<Map<K, VI>>, output, derive)
-        output.__updated = true
+        return output_cache
+    end
 
-        return output
-    elseif type(input) == "table" then
-        local output: Map<K, VO> = table.create(#input :: any) :: {}
+    local function derive()
+        return recompute(input())
+    end
 
-        for k, vi in input :: Map<K, VI> do
-            local vo = transform(k, vi)
-            output[k] = vo
-        end
+    local output, get_output = create(output_cache)
 
-        return output
-    else error(string.format("Invalid type arg #1, expected number or table or state (got %s)", tostring(input)), 2) end
+    local nodes, value = capture(input)
+
+    for _, node in next, nodes do
+        link(node, output, derive)
+    end
+
+    output.cache = recompute(value)
+
+    return get_output
 end
 
-return (map :: any) ::  ( <V>(input: number, transform: (number) -> V) -> Map<number, V> ) &
-                        ( <K, VI, VO>(input: Map<K, VI>, transform: (K, VI) -> VO) -> Map<K, VO> ) &
-                        ( <K, VI, VO>(input: State<Map<K, VI>>, transform: (K, VI) -> VO, cleanup: (VO) -> ()?)
-                            -> State<Map<K, VO>> )
+return map

src/source.lua

@@ -11,15 +11,13 @@ local get = graph.get
 local set = graph.set
 
 
-type State<T> = (() -> T) & ((T) -> T)
+type Source<T> = (() -> T) & ((T) -> T)
 
-local function source<T>(value: T | () -> T): State<T>
-    if type(value) == "function" then value = value() end
-
-    local node = create(value :: T)
+local function source<T>(value: T): Source<T>
+    local node, get_value = create(value :: T)
 
     return function(...): T
-        if select("#", ...) == 0 then return get(node) end
+        if select("#", ...) == 0 then return get_value() end
 
         local v = ... :: T
         if node.cache == v and type(v) ~= "table" then return v end
@@ -29,4 +27,4 @@ local function source<T>(value: T | () -> T): State<T>
     end
 end
 
-return source
+return source :: (<T>(value: T) -> Source<T>) & (<T>() -> Source<T>)

src/watch.lua

@@ -10,7 +10,7 @@ local capture = graph.capture
 
 local function watch(effect: () -> ()): () -> ()
     -- todo: call cleanup on initial debug call when strict
-    local nodes, cleanup = capture(effect :: () -> (() -> ()?))
+    local nodes, cleanup = capture(effect :: () -> (() -> ()?), nil)
 
     nodes = table.clone(nodes)
 

test/tests.luau

@@ -22,9 +22,6 @@ local function weak<T>(t: T & {}): T
     return t
 end
 
--- weak reference table used for gc tests
---local wref = setmetatable({}, { __mode = "kv" }) :: any
-
 TEST("graph", function()
     local graph = require "src/graph"
     local create = graph.create
@@ -35,12 +32,12 @@ TEST("graph", function()
     local link = graph.link
     local set_effect = graph.set_effect
 
-    do CASE "Create"
+    do CASE "Node creation"
         local node = create(1)
         CHECK(get(node) == 1)
     end
 
-    do CASE "Read/write"
+    do CASE "Node value"
         local node = create(0)
         set(node, 1)
         CHECK(get(node) == 1)
@@ -48,7 +45,7 @@ TEST("graph", function()
         CHECK(get(node) == 2)
     end
 
-    do CASE "Capture"
+    do CASE "Capture nodes"
         local node1 = create(nil)
         local node2 = create(nil)
         local nodes = capture(function()
@@ -58,132 +55,126 @@ TEST("graph", function()
         CHECK(nodes[2] == node2)
     end
 
-    do CASE "Link"
+    do CASE "Linking nodes"
         local parent = create(1)
         local child = create(0)
+
         link(parent, child, function() 
             return get(parent)
         end)
+
         set(parent, get(parent) + 1)
-        CHECK(get(child) == 2)
+        CHECK(get(child) == 2) -- child should automatically update
     end
 
-    do CASE "Capture and link"
+    do CASE "Capture and link nodes"
         local parent = create(1)
-        local child = create(nil :: any)
+        local child = create()
 
-        capture_and_link(child, function()
+        child.cache = capture_and_link(child, function()
             return tostring(get(parent))
         end)
 
-        set(parent, get(parent) + 1)
+        set(parent, 2)
         CHECK(get(child) == "2")
     end
 
     --[[
     do CASE "Scoped captures"
-        -- table.find but uses `rawequal` since nodes have overloaded __eq metamethod
-        local function rawfind(t, x)
-            for i, v in ipairs(t) do
-                if rawequal(x, v) then
-                    return true
-                end
-            end
-            return false
-        end
+        local a = create(0)
+        local b = create(nil :: any)
 
-        local a = graph.create(1)
-        local b = graph.create(1)
+        local count = 0
         
-        graph.link(a, b, function() return get(a) end)
-        set(a, get(a) + 1) -- mark `b` for recomputation
+        b.cache = capture_and_link(b, function()
+            count += 1
+            local data = get(a)
+            local c = create(data)
+            get(c)
+            return c
+        end)
 
-        -- `a` and `b` should be referenced
-        local captures = graph.capture(function(from) return from(b) end)
+        local c = get(b)
 
-        -- check that only `b` was referenced
-        CHECK(not rawfind(captures, a))
-        CHECK(rawfind(captures, b))
-
-        -- repeat for `capture_and_link`
-        local c = graph.create(1)
-        set(a, get(a) + 1) -- mark `b` for recomputation again
-        capture_and_link(c, function(from) return from(b) end)
-        -- check that only `b` was linked
-        CHECK(not rawfind(assert(a.__children), c))
-        CHECK(rawfind(assert(b.__children), c))
+        CHECK(count == 1)
+        set(c, 1)
+        CHECK(count == 1)
+        set(a, 1)
+        CHECK(count == 2)
     end
-]]
+    ]]
 
     do CASE "Nodes garbage collection"
-        local wref
-        do
-            wref = weak { create(1) }
-        end
+        local wref = weak { create(1) }
         gc()
         CHECK(not wref[1])
     end
 
     do CASE "Node effect garbage collection"
-        local wref
         do
-            local function factory(p) -- factory function to prevent closure caching
-                return function()
-                    return get(p)
-                end
-            end
-
-            local node = create(1)
+            local wref
 
             do
-                local effect1 = factory(node)
-                local effect2 = factory(node)
-
-                wref = weak { effect1, effect2, node :: any }
-
-                set_effect(node, effect1, {})
-                set_effect(node, effect2, true)
-            end
-
-            gc()
-
-            CHECK(not wref[1]) -- effect1 should gc since nothing is referencing table `t`
-            CHECK(wref[2]) -- effect2 should not gc as `true` is not garbage collectable
-        end
-
-        gc()
-        CHECK(not wref[3] and not wref[2]) -- node should now gc along with effect2
-
-        do -- same test but for multiple nodes referenced by watcher
-            local function factory(a, b)
-                return function()
-                    return get(a), get(b)
+                local function factory(p) -- factory function to prevent closure caching
+                    return function()
+                        return get(p)
+                    end
                 end
+
+                local node = create(1)
+                
+                do
+                    local effect1 = factory(node)
+                    local effect2 = factory(node)
+
+                    wref = weak { e1 = effect1, e2 = effect2, n = node}
+
+                    set_effect(node, effect1, {})
+                    set_effect(node, effect2, true)
+                end
+
+                gc()
+                CHECK(not wref.e1) -- effect1 should gc since nothing is referencing table `t`
+                CHECK(wref.e2) -- effect2 should not gc as `true` is not garbage collectable
             end
 
-            local node1 = create(1)
-            local node2 = graph.create(1)
-            local effect = factory(node1, node2)
-            wref.node1 = node1
-            wref.node2 = node2
-            wref.effect = effect
-
-            local t1 = {}
-            set_effect(node1, effect, t1)
-            set_effect(node2, effect, t1)
-
-            t1 = nil :: any
-            effect = nil :: any
-            
             gc()
-
-            CHECK(not wref.effect)
+            CHECK(not wref.n and not wref.e2) -- node should now gc along with effect2
         end
 
-        gc()
+        do
+            local wref
 
-        CHECK(not wref.node1)
-        CHECK(not wref.node2)
+            do -- same test but for multiple nodes referenced by watcher
+                local function factory(a, b)
+                    return (function(c, d)
+                        return function()
+                            return get(c), get(d)
+                        end
+                    end)(a, b)
+                end
+
+                local node1 = create(1)
+                local node2 = create(1)
+
+                do 
+                    local effect = factory(node1, node2)
+
+                    wref = weak { n1 = node1, n2 = node2, e = effect }
+
+                    local t1 = {}
+                    set_effect(node1, effect, t1)
+                    set_effect(node2, effect, t1)
+                end
+
+                gc()
+                CHECK(not wref.e)
+            end
+
+            gc()
+            CHECK(not wref.n1)
+            CHECK(not wref.n2)
+        end
     end
 end)
 
@@ -191,14 +182,14 @@ TEST("source()", function()
     local source = vide.source
     local watch = vide.watch
 
-    do CASE "source value"
+    do CASE "Create source"
         local state = source(1)
         CHECK(state() == 1)
     end
 
-    do CASE "Setter"
+    do CASE "Set and get source value"
         local state = source(1)
-        state(2) -- set directly
+        state(2)
         CHECK(state() == 2)
     end
 
@@ -210,45 +201,60 @@ TEST("source()", function()
             state()
             updates += 1
         end)
+
+        CHECK(updates == 0)
         state(1)
         CHECK(updates == 0)
         state(2)
         CHECK(updates == 1)
     end
+
+    do CASE "Does update if same value is table"
+        local state = source {}
+
+        local updates = -1
+        watch(function()
+            state()
+            updates += 1
+        end)
+
+        CHECK(updates == 0)
+        state(state())
+        CHECK(updates == 1)
+    end
 end)
 
 TEST("derive()", function()
     local source = vide.source
     local derive = vide.derive
 
-    do CASE "Derive new value on state change"
-        local state = source(1)
+    do CASE "Derive new value on source change"
+        local inputA = source(1)
+        local inputB = source(2)
 
-        local derived = derive(function()
-            return tostring(state())
+        local output = derive(function()
+            return tostring(inputA() + inputB())
         end)
 
-        CHECK(derived() == "1") -- check initial run during detection
-        state(state() + 1)
-        CHECK(derived() == "2") -- check updates
+        CHECK(output() == "3")
+        inputA(2)
+        CHECK(output() == "4")
     end
 
-    do CASE "Derive from updated"
-        do
-            local a = source(1)
+    do CASE "Derive transformed source"
+        local input = source(1)
 
-            local b = derive(function()
-                return a() + 1
-            end)
-
-            a(2)
-
-            local c = derive(function()
-                return b() + 1
-            end)
-
-            CHECK(c() == 4)
+        local transform = function()
+            return tostring(input())
         end
+
+        local output = derive(function()
+            return tonumber(transform())
+        end)
+
+        CHECK(output() == 1)
+        input(2)
+        CHECK(output() == 2)
     end
 
     --[[
@@ -271,29 +277,35 @@ TEST("derive()", function()
 
     do CASE "Garbage collection"
         do -- check that `b` does not allow gc of `a`
-            local a = source(1)
+            local wref, b
             
-            local _b = derive(function()
-                return a()
-            end)
+            do
+                local a = source(1)
     
-            local wref = weak { a }
-            a = nil :: any
+                b = derive(function()
+                    return a()
+                end)
+
+                wref = weak { a }
+            end
 
             gc()
-
-            CHECK(not wref[1]) 
+            CHECK(wref[1])
+            b()
         end
 
         do -- check that `a` allows gc of `b`
             local a = source(1)
 
-            local b = derive(function()
-                return a()
-            end)
+            local wref
 
-            local wref = weak { b }
-            b = nil :: any
+            do
+                local b = derive(function()
+                    return a()
+                end)
+
+                wref = weak { b }
+            end
 
             gc()
             CHECK(not wref[1])
@@ -301,9 +313,9 @@ TEST("derive()", function()
     end
 
     do CASE "Garbage collection 2"
-        -- creats a chain `a -> b -> c` where `a` is the root
+        -- creats a chain `a -> b -> c` where `a` is the source
         local function setup()
-            local a = source(1)
+            local a = source(0)
 
             local b = derive(function()
                 return a()
@@ -316,7 +328,7 @@ TEST("derive()", function()
             return weak { a, b, c }, a, b, c
         end
 
-        do -- check that b and c can gc if a is referenced
+        do -- check that `b` and `c` can gc if `a` is referenced
             local wref, _a = setup()
 
             gc()
@@ -324,7 +336,7 @@ TEST("derive()", function()
             CHECK(not wref[3])
         end
 
-        do -- check that a and b wont gc if c is referenced
+        do -- check that `a` and `b` wont gc if `c` is referenced
             local weak, _a, _b, _c = setup()
 
             _a, _b = nil :: any, nil :: any
@@ -334,16 +346,15 @@ TEST("derive()", function()
             CHECK(weak[2])
         end
 
-        do -- check that b wont gc if a and c are referenced
+        do -- check that `b` wont gc if `a` and `c` are referenced
             local weak, a, _b, c = setup()
 
             _b = nil :: any
 
             gc()
+            CHECK(weak[2])
 
             a(2)
-    
-            CHECK(weak[2])
             CHECK(c() == 2)
         end
     end
@@ -356,35 +367,33 @@ TEST("watch()", function()
     do CASE "Capture states"
         local a = source(1)
         local b = source(1)
-        local runcount = 0
 
+        local runcount = -1
         watch(function()
             a()
             b()
             runcount += 1
         end)
 
-        CHECK(runcount == 1) -- immediate callback execution
+        CHECK(runcount == 0)
         a(2)
-        CHECK(runcount == 2)
+        CHECK(runcount == 1)
         b(2)
-        CHECK(runcount == 3)
+        CHECK(runcount == 2)
     end
 
     do CASE "Stop watch"
         local a = source(1)
-        local b = source(1)
-        local runcount = 0
 
+        local runcount = -1
         local unwatch = watch(function()
             a()
             runcount += 1
         end)
         
-        CHECK(runcount == 1)
         unwatch()
         a(2)
-        CHECK(runcount == 1)
+        CHECK(runcount == 0)
     end
 
     do CASE "Side-effect cleanup"
@@ -428,24 +437,28 @@ TEST("watch()", function()
             end
 
             gc()
-            CHECK(wref[1]) -- should still exist
-
+            CHECK(wref[1])
         end
 
         do -- watcher can gc if stopped
             local state = source(1)
-            local effect = factory(state)
             
-            local unwatch = watch(effect)
+            local wref, unwatch
 
-            local wref = weak { effect }
-            effect = nil :: any
+            do
+                local effect = factory(state)
+                unwatch = watch(effect)
+                wref = weak { effect }
+            end
 
             gc()
-            CHECK(wref[1]) -- should still exist
-            unwatch(); unwatch = nil :: any
+            CHECK(wref[1])
+
+            unwatch()
+            unwatch = nil :: any -- unwatch holds ref to effect
+
             gc()
-            CHECK(not wref[1]) -- should gc
+            CHECK(not wref[1])
 
         end
 
@@ -460,20 +473,7 @@ TEST("watch()", function()
             end
 
             gc()
-
-            CHECK(not wref[1]) -- should gc
-        end
-
-        do -- watcher can gc if no state captured
-            local effect = factory(function() end)
-        
-            watch(effect)
-
-            local wref = weak { effect }
-            effect = nil :: any
-
-            gc()
-            CHECK(not wref[1]) -- should gc
+            CHECK(not wref[1])
         end
     end
 end)
@@ -489,7 +489,7 @@ TEST("create()", function()
         CHECK(frame.BorderColor3 == defaults.Frame.BorderColor3)
     end
 
-    do CASE "Assign custom properties"
+    do CASE "Set properties"
         local text = create "TextLabel" {
             Name = "Label",
             Text = "test"
@@ -498,14 +498,23 @@ TEST("create()", function()
         CHECK(text.Text == "test")
     end
 
+    do CASE "Set nested properties"
+        local text = create "TextLabel" {
+            { Name = "Label" },
+            Group = { Text = "test" }
+        }
+        CHECK(text.Name == "Label")
+        CHECK(text.Text == "test")
+    end
+
     do CASE "Independent"
         local frame = create "Frame"
         CHECK(frame {} ~= frame {})
     end
 
-    do CASE "Assign children"
+    do CASE "Set children"
         local frame = create "Frame" {
-            create "TextLabel" { Name = "A" } :: any,
+            create "TextLabel" { Name = "A" },
             create "TextLabel" { Name = "B" },
             {
                 create "TextLabel" { Name = "C" } :: any,
@@ -513,18 +522,21 @@ TEST("create()", function()
                 {
                     create "TextLabel" { Name = "E" }
                 }
+            },
+            Children = {
+                create "TextLabel" { Name = "F" } :: any,
+                { create "TextLabel" { Name = "G" } }
             }
         }
+
         CHECK(frame:FindFirstChild "A")
         CHECK(frame:FindFirstChild "B")
         CHECK(frame:FindFirstChild "C")
         CHECK(frame:FindFirstChild "D")
         CHECK(frame:FindFirstChild "E")
 
-        local image = create "ImageLabel" {
-            create "TextLabel" { Name = "A" }
-        }
-        CHECK(image:FindFirstChild "A")
+        CHECK(frame:FindFirstChild "F")
+        CHECK(frame:FindFirstChild "G")
     end
 
     do CASE "Binding properties to state"
@@ -547,7 +559,7 @@ TEST("create()", function()
     end
 
     do CASE "Binding garbage collection"
-        do -- instance should gc despite property bound to state
+        do -- instance should gc when unparented
             local state = source("Hi")
 
             local wref = weak {
@@ -560,7 +572,7 @@ TEST("create()", function()
             CHECK(not wref[1])
         end
 
-        do -- instance should NOT gc despite property bound to state when parented
+        do -- instance should not gc when parented
             local state = source("Hi")
 
             local parent = create "Frame" {}
@@ -587,7 +599,7 @@ TEST("create()", function()
             CHECK(not wref[1])
         end
         
-        do -- state should not gc once exits scope while instance still exists
+        do -- instance does not allow gc of state
             local label
             local wref
 
@@ -621,34 +633,32 @@ TEST("create()", function()
             gc()
             CHECK(not wref.text)
             CHECK(not wref.box)
-
         end
         
-        --[[
         do -- binding should gc despite state still existing after instance is gc
             local state = source("Hi")
 
+            local node = require "src/graph".capture(state)[1]
+
+            local wref
+
             do
                 local instance = create "TextLabel" {
                     Text = state,
                 }
 
-                local wref = {
+                wref = weak {
                     instance = instance,
-                    brinding = next((state :: any).effects
+                    binding = next(node.effects)
                 }
-
-                wref.instance = instance
-                wref.binding = )
             end
             
             CHECK(wref.binding)
 
             gc()
-
             CHECK(not wref.instance)
             CHECK(not wref.binding)
-        end]]
+        end
     end
 
     do CASE "Bind same state to multiple instance properties"
@@ -668,7 +678,7 @@ TEST("create()", function()
     end
 
     do CASE "Bind children"
-        local state = source({} :: {}?)
+        local state = source()
 
         local a, b, c = 
             create "TextLabel" { Name = "A" },
@@ -697,30 +707,27 @@ TEST("create()", function()
         CHECK(#frame:GetChildren() == 0)
     end
 
-    --[[
     do CASE "Parent set to nil by state does not allow gc"
-        -- this is technically a bug but we test for this anyways to confirm behavior
-        local parent = create "Frame" { Name = "Parent" }
-        local state = source(parent :: Frame?)
+        local frame = create "Frame" { Name = "Parent" }
+        local parent = source(frame :: Frame?)
 
-        do
-            wref.child = create "Frame" { Parent = state, Name = "Child" } :: Frame?
-        end
+        local wref = weak {
+            create "TextLabel" { Parent = parent, Name = "Child" }
+        }
 
         gc()
-        CHECK(wref.child)
+        CHECK(wref[1])
 
-        set(nil)
+        parent(nil)
 
         gc()
-        CHECK(wref.child)
+        CHECK(wref[1])
 
-        wref.child:Destroy()
+        wref[1]:Destroy()
 
         gc()
-        CHECK(not wref.child)
+        CHECK(not wref[1])
     end
-    ]]
 
     do CASE "GC test"
         local wref
@@ -745,100 +752,64 @@ TEST("create()", function()
         end
 
         gc()
-
         CHECK(wref.data and wref.proxy)
     end
-
-    
 end)
 
 TEST("map()", function()
     local source = vide.source
-    local unsource = vide.unsource
     local map = vide.map
 
-    do CASE "Use integer"
-        local n = 5
-
-        local t = map(n, function(i)
-            return tostring(i)
-        end)
-
-        for i = 1, n do
-            CHECK(tostring(i) == t[i])
-        end
-    end
-
-    do CASE "Use table"
-        local t = { 1, 2, 3, 4, 5 }
-
-        local t2 = map(t, function(_, v)
-            return tostring(v)
-        end)
-
-        for i, v in t do
-            CHECK(tostring(v) == t2[i])
-        end
-    end
-
     do CASE "Use state"
-        local state = source { 1, 2, 3 }
+        local input = source { 1, 2, 3 }
 
-        local derived = map(state, function(_, v)
-            return tostring(v)    
+        local output = map(input, function(v, k)
+            return tostring(v())    
         end)
 
-        local t = derived()
-
-        for i, v in next, state() do
-            CHECK(tostring(v) == t[i])
-        end
+        CHECK("" .. input()[1] == output()[1])
+        CHECK("" .. input()[2] == output()[2])
+        CHECK("" .. input()[3] == output()[3])
     end
 
     do CASE "Cache result"
-        local state, set = source { 1, 2, 3 }
+        local input = source { 1, 2, 3 }
 
         local runcount = table.create(3, 0)
 
-        local derived = map(state, function(i, v)
+        local output = map(input, function(v, i)
             runcount[i] += 1
-            return tostring(v)    
+            return v
         end)
 
-        local _ = derived() -- trigger evaluation (so the next set is forced to be re-calculated)
-        set { 1, 2, 4 }
+        input { 1, 2, 4 }
 
-        local t = derived()
-
-        CHECK(t[1] == "1")
-        CHECK(t[2] == "2")
-        CHECK(t[3] == "4")
+        CHECK(output()[1]() == 1)
+        CHECK(output()[2]() == 2)
+        CHECK(output()[3]() == 4)
 
         CHECK(runcount[1] == 1)
         CHECK(runcount[2] == 1)
-        CHECK(runcount[3] == 2)
+        CHECK(runcount[3] == 1)
     end
 
     do CASE "Removal reflected"
-        local state, set = source { 1, 2, 3 }
+        local input = source { 1, 2, 3 }
 
-        local derived = map(state, function(i, v)
-            return tostring(v)    
+        local output = map(input, function(v, i)
+            return v 
         end)
 
-        local _ = derived() -- trigger evaluation (so the next set is forced to be re-calculated)
-        set { 1, 2 }
+        input { 1, 2 }
 
-        local t = derived()
+        local t = output()
 
-        CHECK(t[1] == "1")
-        CHECK(t[2] == "2")
+        CHECK(t[1]() == 1)
+        CHECK(t[2]() == 2)
         CHECK(t[3] == nil)
     end
 
-    local create = vide.create
-    local Children = vide.Children
-
+--[[
     do CASE "Bind children"
         local state, set = source { "A", "B", "C" }
 
@@ -919,7 +890,7 @@ TEST("map()", function()
             gc()
             CHECK(not wref.derived)
         end
-    end
+    end]]
 end)
 
 TEST("spring()", function()
@@ -980,7 +951,6 @@ end)
 
 TEST("Event", function()
     local create = vide.create
-    local Event = vide.Event
     local source = vide.source
 
     do CASE "Connect event"

todo.md

@@ -35,6 +35,7 @@ Index
 For
 untrack
 batch
+async/loading/suspense
 
 ## version 1