hakowork/vide
3
0
Fork 0
mirror of https://github.com/centau/vide.git synced 2026-08-20 14:41:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use vector.max to check spring activity (#44)

Browse source 
* Use `vector.max` to check spring activity

* Revert unnecessary changes
This commit is contained in:
richard 2024-12-04 18:00:37 -08:00 • committed by GitHub
parent caa9eaf733
commit 3b8d9098c0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/spring.luau
View file

@ -30,11 +30,12 @@ local update_descendants = graph.update_descendants
local push_child_to_scope = graph.push_child_to_scope local push_child_to_scope = graph.push_child_to_scope
local UPDATE_RATE = 120 local UPDATE_RATE = 120
local TOLERANCE = 0.0001 local TOLERANCE = 0.001
local TOLERANCE_VECTOR = vector.create(TOLERANCE, TOLERANCE, TOLERANCE)
type Vec3 = Vector3 type Vec3 = Vector3
local function Vec3(x: number?, y: number?, z: number?): Vec3 local function Vec3(x: number, y: number, z: number): Vec3
return vector.create(x, y, z) return vector.create(x, y, z)
end end
@ -268,13 +269,16 @@ local function update_spring_sources()
x0_456, x1_456, v_456 = x0_456, x1_456, v_456 =
data.x0_123, data.x1_123, data.v_123, data.x0_123, data.x1_123, data.v_123,
data.x0_456, data.x1_456, data.v_456 data.x0_456, data.x1_456, data.v_456
local dx_123, dx_456 =
x0_123 - x1_123,
x0_456 - x1_456
-- todo: can this false positive? local max_difference = vector.max(
if vector.magnitude(v_123 + v_456 + dx_123 + dx_456) < TOLERANCE then vector.abs(x0_123 - x1_123 :: any),
vector.abs(x0_456 - x1_456 :: any),
vector.abs(v_123 :: any),
vector.abs(v_456 :: any),
TOLERANCE_VECTOR
)
if max_difference == TOLERANCE_VECTOR then
-- close enough to target, unshedule spring and set value to target -- close enough to target, unshedule spring and set value to target
table.insert(remove_queue, data) table.insert(remove_queue, data)
output.cache = data.source_value output.cache = data.source_value