hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-21 03:36:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Catch more sync failures (#845)

Browse source 
- Catch removal failures
- Catch name change failures
- Don't remove IDs for instances if they weren't actually destroyed
This commit is contained in:
boatbomber 2024-01-31 17:07:01 -08:00 • committed by GitHub
parent 106a01223e
commit f3b0b0027e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 36 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

11
plugin/src/PatchTree.lua
View file

@ -437,8 +437,13 @@ function PatchTree.updateMetadata(tree, patch, instanceMap, unappliedPatch)
continue
end
for _, change in node.changeList do
if not failedChange.changedProperties[change[1]] then
-- This change didn't fail
local property = change[1]
local propertyFailedToApply = if property == "Name"
then failedChange.changedName ~= nil -- Name is not in changedProperties, so it needs a special case
else failedChange.changedProperties[property] ~= nil
if not propertyFailedToApply then
-- This change didn't fail, no need to mark
continue
end
if change[4] == nil then
@ -446,7 +451,7 @@ function PatchTree.updateMetadata(tree, patch, instanceMap, unappliedPatch)
else
change[4].isWarning = true
end
Log.trace(" Marked property as warning: {}.{}", node.name, change[1])
Log.trace(" Marked property as warning: {}.{}", node.name, property)
end
end
for failedAdditionId in unappliedPatch.added do