Enhance error handling and improve script tracking in RojoTree and ServeSession

- Added a test to verify the functionality of script tracking updates in RojoTree, ensuring proper addition and removal of script references. - Improved error handling in ServeSession by clearing temporary script IDs upon disconnection to prevent potential memory leaks. - Updated API logic to filter out empty properties and children during instance addition, enhancing the integrity of the synchronization process. These changes aim to optimize script management and enhance the robustness of the session handling and tree operations.
2026-10-22 21:41:37 +00:00 · 2026-02-28 11:16:10 -06:00 · 2026-02-28 11:16:10 -06:00 · ec51c14a41
commit ec51c14a41
parent 9d6b48a53e
5 changed files with 33 additions and 79 deletions
--- a/TODO.txt
+++ b/TODO.txt
@ -355,78 +355,3 @@ this needs to be slugified when the name exactly matches init, ignoring case [fo

 [one shot mode change]
 new changes that come in / out during the review menu on the plugin is really disorienting.
-
-[error]
-[INFO  librojo::change_processor] Two-way sync: Removing instance Ref(Some(11172145805454499324864790020248300740)) from tree (path: d:\UserGenerated\knockout\src\ServerScriptService\Services\AdminAbuseService\EmperorPenguin\EventVFXSetup\VisalizationInstancesV2\Visualize\VisualizeV2\init.luau)
-[INFO  librojo::change_processor] Two-way sync: Removing instance Ref(Some(250896002424020262431971720464633879491)) from tree (path: d:\UserGenerated\knockout\src\ServerScriptService\Services\AdminAbuseService\EmperorPenguin\EventVFXSetup\VFX\ShopAura\BillboardGui\Script.client.luau)
-[INFO  librojo::change_processor] Two-way sync: Removing instance Ref(Some(180523706273884596638310961780081579965)) from tree (path: d:\UserGenerated\knockout\src\ServerScriptService\Services\AdminAbuseService\EmperorPenguin\EventVFXSetup\VFX)
-[INFO  librojo::change_processor] Two-way sync: Removing instance Ref(Some(255012798697385670746832788816389180140)) from tree (path: d:\UserGenerated\knockout\src\ServerScriptService\Services\AdminAbuseService\EmperorPenguin\EventVFXSetup\VFX\ShopAura)
-[INFO  librojo::change_processor] Two-way sync: Removing instance Ref(Some(327927689482872520713513681823365738785)) from tree (path: d:\UserGenerated\knockout\src\ServerScriptService\Services\AdminAbuseService\EmperorPenguin\EventVFXSetup)
-[INFO  librojo::change_processor] Two-way sync: Writing Source to d:\UserGenerated\knockout\src\ServerScriptService\Services\AdminAbuseService\Disco\init.luau
-[ERROR atlas] Rojo crashed! You are running Rojo 8.4.1.
-[ERROR atlas] This is probably a Rojo bug.
-[ERROR atlas] 
-[ERROR atlas] Please consider filing an issue: https://github.com/UserGeneratedLLC/rojo/issues
-[ERROR atlas] 
-[ERROR atlas] Details: called `Option::unwrap()` on a `None` value
-[ERROR atlas] in file src\snapshot\tree.rs on line 471
-   0: backtrace::backtrace::win64::trace
-             at C:\Users\Joe\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\backtrace-0.3.76\src\backtrace\win64.rs:85
-      backtrace::backtrace::trace_unsynchronized
-             at C:\Users\Joe\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\backtrace-0.3.76\src\backtrace\mod.rs:66
-      backtrace::backtrace::trace<backtrace::capture::impl$4::create::closure_env$0>
-             at C:\Users\Joe\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\backtrace-0.3.76\src\backtrace\mod.rs:53
-   1: backtrace::capture::Backtrace::create
-             at C:\Users\Joe\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\backtrace-0.3.76\src\capture.rs:294
-   2: backtrace::capture::Backtrace::new
-             at C:\Users\Joe\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\backtrace-0.3.76\src\capture.rs:259
-   3: atlas::main::closure$0
-             at D:\UserGenerated\rojo\src\main.rs:48
-   4: std::panicking::panic_with_hook
-             at /rustc/254b59607d4417e9dffbc307138ae5c86280fe4c/library\std\src\panicking.rs:833
-   5: std::panicking::panic_handler::closure$0
-             at /rustc/254b59607d4417e9dffbc307138ae5c86280fe4c/library\std\src\panicking.rs:691
-   6: std::sys::backtrace::__rust_end_short_backtrace<std::panicking::panic_handler::closure_env$0,never$>
-             at /rustc/254b59607d4417e9dffbc307138ae5c86280fe4c/library\std\src\sys\backtrace.rs:176
-   7: std::panicking::panic_handler
-             at /rustc/254b59607d4417e9dffbc307138ae5c86280fe4c/library\std\src\panicking.rs:689
-   8: core::panicking::panic_fmt
-             at /rustc/254b59607d4417e9dffbc307138ae5c86280fe4c/library\core\src\panicking.rs:80
-   9: core::panicking::panic
-             at /rustc/254b59607d4417e9dffbc307138ae5c86280fe4c/library\core\src\panicking.rs:150
-  10: core::option::unwrap_failed
-             at /rustc/254b59607d4417e9dffbc307138ae5c86280fe4c/library\core\src\option.rs:2175
-  11: librojo::snapshot::tree::RojoTree::remove_metadata
-             at D:\UserGenerated\rojo\src\snapshot\tree.rs:471
-      librojo::snapshot::tree::RojoTree::remove
-             at D:\UserGenerated\rojo\src\snapshot\tree.rs:165
-  12: librojo::snapshot::patch_apply::apply_remove_instance
-             at D:\UserGenerated\rojo\src\snapshot\patch_apply.rs:208
-      librojo::snapshot::patch_apply::apply_patch_set
-             at D:\UserGenerated\rojo\src\snapshot\patch_apply.rs:32
-  13: librojo::change_processor::JobThreadContext::handle_tree_event
-             at D:\UserGenerated\rojo\src\change_processor.rs:1858
-  14: librojo::change_processor::impl$1::start::closure$0
-             at D:\UserGenerated\rojo\src\change_processor.rs:174
-      std::sys::backtrace::__rust_begin_short_backtrace<librojo::change_processor::impl$1::start::closure_env$0,enum2$<core::result::Result<tuple$<>,crossbeam_channel::err::RecvError> > >
-             at C:\Users\Joe\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\sys\backtrace.rs:160
-  15: std::thread::lifecycle::spawn_unchecked::closure$1::closure$0
-             at C:\Users\Joe\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\thread\lifecycle.rs:92
-      core::panic::unwind_safe::impl$25::call_once
-             at C:\Users\Joe\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\panic\unwind_safe.rs:274
-      std::panicking::catch_unwind::do_call
-             at C:\Users\Joe\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\panicking.rs:581
-      std::panicking::catch_unwind
-             at C:\Users\Joe\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\panicking.rs:544
-      std::panic::catch_unwind
-             at C:\Users\Joe\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\panic.rs:359
-      std::thread::lifecycle::spawn_unchecked::closure$1
-             at C:\Users\Joe\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\thread\lifecycle.rs:90
-      core::ops::function::FnOnce::call_once<std::thread::lifecycle::spawn_unchecked::closure_env$1<librojo::change_processor::impl$1::start::closure_env$0,enum2$<core::result::Result<tuple$<>,crossbeam_channel::err::RecvError> > >,tuple$<> >
-             at C:\Users\Joe\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:250
-  16: std::sys::thread::windows::impl$0::new::thread_start
-             at /rustc/254b59607d4417e9dffbc307138ae5c86280fe4c/library\std\src\sys\thread\windows.rs:59
-  17: BaseThreadInitThunk
-  18: RtlUserThreadStart
-Process exited with code 1
-