hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 14:01:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor service encoding to streamline properties handling

Browse source 
- Removed the encoding of attributes and tags from the `encodeService` function, consolidating their inclusion into the properties map as `Variant::Attributes(...)` and `Variant::Tags(...)`.
- Updated the `ServiceChunk` struct to reflect these changes, ensuring a more efficient serialization process during syncback operations.
- Adjusted related tests to align with the new structure, enhancing overall data management and consistency in service encoding.

These modifications improve the clarity and performance of the service encoding process.
This commit is contained in:
Joe 2026-02-18 08:00:49 -06:00
parent 8070129bca
commit e0fd9077e8
5 changed files with 15 additions and 125 deletions
Download patch file Download diff file Expand all files Collapse all files

47
plugin/src/ChangeBatcher/encodeService.lua
View file

@ -15,8 +15,6 @@ local SKIP_PROPERTIES = {
return function(service: Instance)
local properties = {}
local attributes = {}
local tags = {}
local refs = {}
local classDescriptor = RbxDom.findClassDescriptor(service.ClassName)
@ -25,11 +23,9 @@ return function(service: Instance)
if SKIP_PROPERTIES[propertyName] then
continue
end
if propertyName == "Attributes" or propertyName == "Tags" then
continue
end
local isReadable = propertyMeta.scriptability == "ReadWrite" or propertyMeta.scriptability == "Read"
local isReadable = propertyMeta.scriptability == "ReadWrite"
or propertyMeta.scriptability == "Read"
local doesSerialize = propertyMeta.serialization ~= "DoesNotSerialize"
if isReadable and doesSerialize then
@ -59,26 +55,6 @@ return function(service: Instance)
end
end
local attrOk, attrMap = pcall(function()
return service:GetAttributes()
end)
if attrOk and attrMap and next(attrMap) then
local descriptor = RbxDom.findCanonicalPropertyDescriptor(service.ClassName, "Attributes")
if descriptor then
local encodeOk, encoded = encodeProperty(service, "Attributes", descriptor)
if encodeOk and encoded ~= nil then
attributes = encoded
end
end
end
local tagOk, tagList = pcall(function()
return service:GetTags()
end)
if tagOk and tagList and #tagList > 0 then
tags = tagList
end
local children = service:GetChildren()
local data = buffer.create(0)
if #children > 0 then
@ -90,23 +66,10 @@ return function(service: Instance)
end
end
local result = {
return {
className = service.ClassName,
data = data,
properties = properties,
refs = refs,
}
if next(properties) then
result.properties = properties
end
if next(attributes) then
result.attributes = attributes
end
if #tags > 0 then
result.tags = tags
end
if next(refs) then
result.refs = refs
end
return result
end