mirror of
https://github.com/rojo-rbx/rojo.git
synced 2026-10-23 05:51:39 +00:00
Enhance right-click functionality in PatchVisualizer
- Added support for right-click events in the PatchVisualizer component, allowing users to unselect nodes and manage subtree selections more intuitively. - Updated the TODO list to remove outdated tasks related to the change visualizer, streamlining focus on current issues. These changes aim to improve user interaction and simplify task management within the application.
This commit is contained in:
parent
0ed0b40766
commit
d2f739ece6
2 changed files with 41 additions and 3 deletions
3
TODO.txt
3
TODO.txt
|
|
@ -339,9 +339,6 @@ We need to investigate Tree reconciliation, make sure it's parallel, etc.
|
||||||
I'd really like to just reconcile specific paths that were modified - but i'm not sure if that just defeats the purpose.. need to explore this topic later.
|
I'd really like to just reconcile specific paths that were modified - but i'm not sure if that just defeats the purpose.. need to explore this topic later.
|
||||||
Worst case - we reconcile only on connect, but do so in mega-parallel
|
Worst case - we reconcile only on connect, but do so in mega-parallel
|
||||||
|
|
||||||
[change visualizer]
|
|
||||||
we should support right-click to unselect the bubble (atlas/studio/skip)
|
|
||||||
|
|
||||||
[auto select issue]
|
[auto select issue]
|
||||||
when you commit changes on git, it's considered unchanged. we should send like the last git hash too, like prior to head, too.
|
when you commit changes on git, it's considered unchanged. we should send like the last git hash too, like prior to head, too.
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -243,6 +243,17 @@ function SelectionOption:render()
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end,
|
end,
|
||||||
|
[Roact.Event.MouseButton2Click] = function()
|
||||||
|
if isParentOnly or (isSelected and hasChildren) then
|
||||||
|
if props.onSubtreeRightClick then
|
||||||
|
props.onSubtreeRightClick()
|
||||||
|
end
|
||||||
|
else
|
||||||
|
if props.onRightClick then
|
||||||
|
props.onRightClick()
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end,
|
||||||
}, {
|
}, {
|
||||||
Corner = e("UICorner", {
|
Corner = e("UICorner", {
|
||||||
CornerRadius = UDim.new(0, 3),
|
CornerRadius = UDim.new(0, 3),
|
||||||
|
|
@ -295,6 +306,16 @@ local function SelectionRadio(props)
|
||||||
props.onSubtreeSelectionChange(props.nodeId, "pull")
|
props.onSubtreeSelectionChange(props.nodeId, "pull")
|
||||||
end
|
end
|
||||||
end,
|
end,
|
||||||
|
onRightClick = function()
|
||||||
|
if props.onSelectionChange then
|
||||||
|
props.onSelectionChange(props.nodeId, nil)
|
||||||
|
end
|
||||||
|
end,
|
||||||
|
onSubtreeRightClick = function()
|
||||||
|
if props.onSubtreeSelectionChange then
|
||||||
|
props.onSubtreeSelectionChange(props.nodeId, nil)
|
||||||
|
end
|
||||||
|
end,
|
||||||
}),
|
}),
|
||||||
Skip = e(SelectionOption, {
|
Skip = e(SelectionOption, {
|
||||||
text = "Skip",
|
text = "Skip",
|
||||||
|
|
@ -316,6 +337,16 @@ local function SelectionRadio(props)
|
||||||
props.onSubtreeSelectionChange(props.nodeId, "ignore")
|
props.onSubtreeSelectionChange(props.nodeId, "ignore")
|
||||||
end
|
end
|
||||||
end,
|
end,
|
||||||
|
onRightClick = function()
|
||||||
|
if props.onSelectionChange then
|
||||||
|
props.onSelectionChange(props.nodeId, nil)
|
||||||
|
end
|
||||||
|
end,
|
||||||
|
onSubtreeRightClick = function()
|
||||||
|
if props.onSubtreeSelectionChange then
|
||||||
|
props.onSubtreeSelectionChange(props.nodeId, nil)
|
||||||
|
end
|
||||||
|
end,
|
||||||
}),
|
}),
|
||||||
Atlas = e(SelectionOption, {
|
Atlas = e(SelectionOption, {
|
||||||
text = "Atlas",
|
text = "Atlas",
|
||||||
|
|
@ -337,6 +368,16 @@ local function SelectionRadio(props)
|
||||||
props.onSubtreeSelectionChange(props.nodeId, "push")
|
props.onSubtreeSelectionChange(props.nodeId, "push")
|
||||||
end
|
end
|
||||||
end,
|
end,
|
||||||
|
onRightClick = function()
|
||||||
|
if props.onSelectionChange then
|
||||||
|
props.onSelectionChange(props.nodeId, nil)
|
||||||
|
end
|
||||||
|
end,
|
||||||
|
onSubtreeRightClick = function()
|
||||||
|
if props.onSubtreeSelectionChange then
|
||||||
|
props.onSubtreeSelectionChange(props.nodeId, nil)
|
||||||
|
end
|
||||||
|
end,
|
||||||
}),
|
}),
|
||||||
})
|
})
|
||||||
end
|
end
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue