mirror of
https://github.com/rojo-rbx/rojo.git
synced 2026-10-21 03:36:06 +00:00
Migrate DevSettings to PluginSettings for much better config flow (#572)
* Add the devsetting config options into settings * Create dropdown component and add setting controls * Static dropdwon width and spin arrow * Improve dropdown option contrast and border * Forgot to make the settings page respect the static spacing, oops * Smaller arrow * Vert padding * Reset option for settings * Hide reset button when on default * Respect the logLevel setting * Portal settings out to external typechecking module * Implement new configs using the new singleton Settings * Remove DevSettings * Update test runner to use new settings * More helpful test failure output * Support non-plugin environment * Migrate dropdown to new packages system * Clean up components a tad
This commit is contained in:
parent
17de912608
commit
cdc972a5ce
12 changed files with 309 additions and 167 deletions
|
|
@ -8,12 +8,12 @@ local Packages = Rojo.Packages
|
|||
local Log = require(Packages.Log)
|
||||
local Roact = require(Packages.Roact)
|
||||
|
||||
local DevSettings = require(script.DevSettings)
|
||||
local Settings = require(script.Settings)
|
||||
local Config = require(script.Config)
|
||||
local App = require(script.App)
|
||||
|
||||
Log.setLogLevelThunk(function()
|
||||
return DevSettings:getLogLevel()
|
||||
return Log.Level[Settings:get("logLevel")] or Log.Level.Info
|
||||
end)
|
||||
|
||||
local app = Roact.createElement(App, {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue