hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-20 17:41:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Support changing ClassName in Reconciler.diff

Browse source
This commit is contained in:
Lucien Greathouse 2021-01-16 18:26:30 -07:00
parent 5989ab3b85
commit cc4f4df4f9
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
plugin/src/Reconciler/diff.lua
View file

@ -52,8 +52,9 @@ local function diff(instanceMap, virtualInstances, rootId)
invariant("Cannot diff an instance not present in InstanceMap\nID: {}", id) invariant("Cannot diff an instance not present in InstanceMap\nID: {}", id)
end end
local changedClassName = nil
if virtualInstance.ClassName ~= instance.ClassName then if virtualInstance.ClassName ~= instance.ClassName then
error("unimplemented: support changing ClassName") changedClassName = virtualInstance.ClassName
end end
local changedName = nil local changedName = nil
@ -89,11 +90,11 @@ local function diff(instanceMap, virtualInstances, rootId)
end end
end end
if changedName ~= nil or not isEmpty(changedProperties) then if changedName ~= nil or changedClassName ~= nil or not isEmpty(changedProperties) then
table.insert(patch.updated, { table.insert(patch.updated, {
id = id, id = id,
changedName = changedName, changedName = changedName,
changedClassName = nil, changedClassName = changedClassName,
changedProperties = changedProperties, changedProperties = changedProperties,
changedMetadata = nil, changedMetadata = nil,
}) })