hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 22:11:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor Reconciler tests and update path handling logic

Browse source 
- Updated test descriptions in `diff.spec.lua` and `diff.stress.spec.lua` to reflect changes in behavior regarding duplicate-named children in both real and virtual DOM contexts.
- Adjusted assertions to ensure that duplicate-named children are correctly removed or added based on the new matching logic.
- Refactored `hydrate.lua` and `matching.lua` to streamline the matching process by removing unnecessary parameters, enhancing clarity and maintainability.
- Updated metadata references in various test files to include the `.model.json5` extension for consistency in path handling.

These changes improve the accuracy of reconciliation tests and enhance the overall robustness of the Reconciler's path handling logic.
This commit is contained in:
Joe 2026-02-17 04:46:54 -06:00
parent 3ad3c21c01
commit bb9d241253
18 changed files with 129 additions and 94 deletions
Download patch file Download diff file Expand all files Collapse all files

2
plugin/src/Reconciler/hydrate.lua
View file

@ -41,7 +41,7 @@ local function hydrate(instanceMap, virtualInstances, rootId, rootInstance)
end
-- Use the 3-pass matching algorithm to pair virtual ↔ studio children
local result = Matching.matchChildren(validVirtualIds, existingChildren, virtualInstances, instanceMap)
local result = Matching.matchChildren(validVirtualIds, existingChildren, virtualInstances)
-- Recursively hydrate matched pairs
for _, pair in result.matched do