hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 05:51:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add matching session caching and native codegen improvements

Browse source 
- Introduced a new matching session caching mechanism in the Lua matching module to enhance performance with native code generation.
- Rewrote the Lua matching algorithm to utilize session-based caching, reducing redundant computations and improving efficiency.
- Updated Rust implementations to include session caching, ensuring consistency across both Lua and Rust.
- Enhanced the `hydrate` function to support session management during instance hydration.
- Added comprehensive tests to validate the new caching mechanism and its integration with existing functionality.

These changes significantly improve the performance and maintainability of the matching process in the application.
This commit is contained in:
Joe 2026-02-18 04:55:31 -06:00
parent 307ac81aec
commit b39c01e5e9
14 changed files with 1674 additions and 461 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/snapshot/patch_compute.rs
View file

@ -19,12 +19,15 @@ use super::{
#[profiling::function]
pub fn compute_patch_set(snapshot: Option<InstanceSnapshot>, tree: &RojoTree, id: Ref) -> PatchSet {
use super::matching::MatchingSession;
let mut patch_set = PatchSet::new();
if let Some(snapshot) = snapshot {
let mut context = ComputePatchContext::default();
let session = MatchingSession::new();
compute_patch_set_internal(&mut context, snapshot, tree, id, &mut patch_set);
compute_patch_set_internal(&mut context, snapshot, tree, id, &mut patch_set, &session);
// Rewrite Ref properties to refer to instance IDs instead of snapshot IDs
// for all of the IDs that we know about so far.
@ -80,6 +83,7 @@ fn compute_patch_set_internal(
tree: &RojoTree,
id: Ref,
patch_set: &mut PatchSet,
session: &super::matching::MatchingSession,
) {
if snapshot.snapshot_id.is_some() {
context
@ -92,7 +96,7 @@ fn compute_patch_set_internal(
.expect("Instance did not exist in tree");
compute_property_patches(&mut snapshot, &instance, patch_set, tree);
compute_children_patches(context, &mut snapshot, tree, id, patch_set);
compute_children_patches(context, &mut snapshot, tree, id, patch_set, session);
}
fn compute_property_patches(
@ -216,6 +220,7 @@ fn compute_children_patches(
tree: &RojoTree,
id: Ref,
patch_set: &mut PatchSet,
session: &super::matching::MatchingSession,
) {
use super::matching::match_forward;
@ -226,12 +231,11 @@ fn compute_children_patches(
let instance_children = instance.children().to_vec();
let snapshot_children = take(&mut snapshot.children);
// Use the recursive change-count scoring + greedy assignment matching algorithm.
let match_result = match_forward(snapshot_children, &instance_children, tree);
let match_result = match_forward(snapshot_children, &instance_children, tree, session);
// Matched pairs: recursively compute patches.
for (snapshot_child, tree_child_id) in match_result.matched {
compute_patch_set_internal(context, snapshot_child, tree, tree_child_id, patch_set);
compute_patch_set_internal(context, snapshot_child, tree, tree_child_id, patch_set, session);
}
// Unmatched snapshots: new instances to be added.