hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-22 21:41:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Move globIgnoredChildren guard before shouldDeleteUnknownInstances

Browse source 
The guard was placed after the early return, so when
ignoreUnknownInstances was false the function exited at line 39
before ever reaching the globIgnoredChildren check. Project nodes
and meta files can override ignoreUnknownInstances independently,
causing incorrect deletions of glob-ignored instances.
This commit is contained in:
Joe 2026-03-07 12:10:35 -06:00
parent 1406c1a1b7
commit 8772077ed1
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
plugin/src/Reconciler/diff.lua
View file

@ -35,17 +35,18 @@ local SCRIPT_CLASS_NAMES = {
}
local function shouldDeleteChild(virtualInstance, childInstance)
if shouldDeleteUnknownInstances(virtualInstance) then
return true
end
-- When the parent has glob-ignored children, suppress ALL deletions
-- (including scripts). This differs from scripts-only mode where
-- scripts are still eligible for deletion.
-- (including scripts) unconditionally. This must be checked before
-- shouldDeleteUnknownInstances because project nodes and meta files
-- can override ignoreUnknownInstances independently.
if virtualInstance.Metadata and virtualInstance.Metadata.globIgnoredChildren then
return false
end
if shouldDeleteUnknownInstances(virtualInstance) then
return true
end
-- In scripts-only mode (where parent has ignoreUnknownInstances: true),
-- we still want to allow deletion of scripts. This ensures deleted
-- script files show up in the sync diff.