hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-20 17:41:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Consistent ordering of CSV fields (#1333)
Some checks failed
CI / Build and Test (push) Has been cancelled
Details
CI / Build and Test-1 (push) Has been cancelled
Details
CI / Build and Test-2 (push) Has been cancelled
Details
CI / Build and Test-3 (push) Has been cancelled
Details
CI / Build and Test-4 (push) Has been cancelled
Details
CI / Check MSRV (push) Has been cancelled
Details
CI / Rustfmt, Clippy, Stylua, & Selene (push) Has been cancelled
Details

Browse source 
Paired with https://github.com/rojo-rbx/rbx-dom/pull/668

This fixes a bug where the first sync of a place with LocalizationTables
would always fail diff, since Roblox computes it at runtime
This commit is contained in:
boyned//Kampfkarren 2026-10-05 18:02:34 -07:00 • committed by GitHub
parent 95262a02e9
commit 7e60406373
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 80 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
rojo-test/build-test-snapshots/end_to_end__tests__build__csv_bug_145.snap
View file

@ -10,7 +10,7 @@ expression: contents
<Item class="LocalizationTable" referent="1">
<Properties>
<string name="Name">normal</string>
<string name="Contents">[{"key":"Count","example":"A number demonstrating issue 145","source":"3","values":{"es":"7"}}]</string>
<string name="Contents">[{"example":"A number demonstrating issue 145","key":"Count","source":"3","values":{"es":"7"}}]</string>
</Properties>
</Item>
</Item>

2
rojo-test/build-test-snapshots/end_to_end__tests__build__csv_bug_147.snap
View file

@ -10,7 +10,7 @@ expression: contents
<Item class="LocalizationTable" referent="1">
<Properties>
<string name="Name">normal</string>
<string name="Contents">[{"key":"Language.Name","source":"English","values":{}},{"key":"Language.Region","source":"United States","values":{}},{"key":"Label.Thickness","source":"Thickness","values":{}},{"key":"Label.Opacity","source":"Opacity","values":{}},{"key":"Toolbar.Undo","source":"Undo","values":{}},{"key":"Toolbar.Redo","source":"Redo","values":{}},{"key":"Toolbar.Camera","source":"Top-down camera","values":{}},{"key":"Toolbar.Saves","source":"Saved drawings","values":{}},{"key":"Toolbar.Preferences","source":"Settings","values":{}},{"key":"Toolbar.Mode.Vector","source":"Vector mode","values":{}},{"key":"Toolbar.Mode.Pixel","source":"Pixel mode","values":{}}]</string>
<string name="Contents">[{"key":"Label.Opacity","source":"Opacity","values":{}},{"key":"Label.Thickness","source":"Thickness","values":{}},{"key":"Language.Name","source":"English","values":{}},{"key":"Language.Region","source":"United States","values":{}},{"key":"Toolbar.Camera","source":"Top-down camera","values":{}},{"key":"Toolbar.Mode.Pixel","source":"Pixel mode","values":{}},{"key":"Toolbar.Mode.Vector","source":"Vector mode","values":{}},{"key":"Toolbar.Preferences","source":"Settings","values":{}},{"key":"Toolbar.Redo","source":"Redo","values":{}},{"key":"Toolbar.Saves","source":"Saved drawings","values":{}},{"key":"Toolbar.Undo","source":"Undo","values":{}}]</string>
</Properties>
</Item>
</Item>

2
rojo-test/build-test-snapshots/end_to_end__tests__build__csv_in_folder.snap
View file

@ -10,7 +10,7 @@ expression: contents
<Item class="LocalizationTable" referent="1">
<Properties>
<string name="Name">normal</string>
<string name="Contents">[{"key":"Ack","example":"An exclamation of despair","source":"Ack!","values":{"es":"¡Ay!"}}]</string>
<string name="Contents">[{"example":"An exclamation of despair","key":"Ack","source":"Ack!","values":{"es":"¡Ay!"}}]</string>
</Properties>
</Item>
</Item>