From 7d08b8990f856cb51e5e38e8fa1d697d42f430f1 Mon Sep 17 00:00:00 2001 From: Joe Date: Sun, 1 Mar 2026 06:51:30 -0600 Subject: [PATCH] Update TODO list and refine selection logic in Confirming page - Removed outdated tasks from the TODO list related to one-shot mode changes, streamlining focus on current issues. - Enhanced the selection logic in the Confirming page to prevent auto-selection of new items when changes are detected, improving user experience during updates. These changes aim to clarify task management and enhance the handling of user selections in the application. --- TODO.txt | 5 ----- plugin/src/App/StatusPages/Confirming.lua | 3 ++- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/TODO.txt b/TODO.txt index b546d3a6..fe29969f 100644 --- a/TODO.txt +++ b/TODO.txt @@ -334,11 +334,6 @@ when you commit changes on git, it's considered unchanged. we need send prior gi right now i believe we are calculating the hashes manually, we CAN use the git hash since our hash schema matches it 1:1. this would be a nice optimization, too. -[one shot mode change] -new changes that come in / out during the pathc visualizer menu on the plugin is really disorienting. -if a new change comes in mid-visualizer syncing, we need to unselect the change completely - not even permitting auto selections or whatever the user had selected (ONLY if that specific file was changed, of course) -this applies to all sync mode which that GUI is being used - [syncback] detect when the output file hash is the same, and dont write to it. because have already loaded it, we can detect this. diff --git a/plugin/src/App/StatusPages/Confirming.lua b/plugin/src/App/StatusPages/Confirming.lua index fc828b8a..9db24a2f 100644 --- a/plugin/src/App/StatusPages/Confirming.lua +++ b/plugin/src/App/StatusPages/Confirming.lua @@ -211,7 +211,8 @@ function ConfirmingPage:didUpdate(prevProps) -- Merge with any new default selections (new items get nil = unselected) for id, selection in pairs(newSelections) do - if updatedSelections[id] == nil then + local wasChanged = self.props.changedIds and self.props.changedIds[id] + if updatedSelections[id] == nil and not wasChanged then updatedSelections[id] = selection end end