hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 05:51:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix server crash when deleting folders

Browse source 
Handle the case where a folder's parent path no longer exists when
processing VFS removal events. This can happen when a folder and its
contents are deleted together, causing a race between removal events.

Added a regression test for this scenario.
This commit is contained in:
warsam 2026-01-27 16:03:44 -08:00
parent 4965165ad5
commit 752be0d56f
8 changed files with 137 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

35
tests/tests/serve.rs
View file

@ -126,6 +126,41 @@ fn remove_file() {
});
}
/// Test that removing a folder (directory) with contents doesn't crash the server.
/// This is a regression test for a bug where deleting a folder would cause a panic
/// due to the parent path no longer existing when processing child removal events.
#[test]
fn remove_folder() {
run_serve_test("remove_folder", |session, mut redactions| {
let info = session.get_api_rojo().unwrap();
let root_id = info.root_instance_id;
assert_yaml_snapshot!("remove_folder_info", redactions.redacted_yaml(info));
let read_response = session.get_api_read(root_id).unwrap();
assert_yaml_snapshot!(
"remove_folder_all",
read_response.intern_and_redact(&mut redactions, root_id)
);
fs::remove_dir_all(session.path().join("src/my-folder")).unwrap();
let socket_packet = session
.get_api_socket_packet(SocketPacketType::Messages, 0)
.unwrap();
assert_yaml_snapshot!(
"remove_folder_subscribe",
socket_packet.intern_and_redact(&mut redactions, ())
);
let read_response = session.get_api_read(root_id).unwrap();
assert_yaml_snapshot!(
"remove_folder_all-2",
read_response.intern_and_redact(&mut redactions, root_id)
);
});
}
#[test]
fn edit_init() {
run_serve_test("edit_init", |session, mut redactions| {