hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-20 17:41:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update nil Ref check and property decode warning to new Rojo protocol (#466)

Browse source 
* Skip empty Refs in new Rojo protocol

* Update warning message for new Rojo protocol
This commit is contained in:
Ayuka 2021-08-09 13:14:59 -05:00 • committed by GitHub
parent e1f9eaefa9
commit 6cc2e919c0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
plugin/src/Reconciler/decodeValue.lua
View file

@ -11,7 +11,7 @@ local function decodeValue(encodedValue, instanceMap)
-- Refs are represented as IDs in the same space that Rojo's protocol uses. -- Refs are represented as IDs in the same space that Rojo's protocol uses.
if ty == "Ref" then if ty == "Ref" then
if value == nil then if value == "00000000000000000000000000000000" then
return true, nil return true, nil
end end

4
plugin/src/Reconciler/diff.lua
View file

@ -75,7 +75,9 @@ local function diff(instanceMap, virtualInstances, rootId)
changedProperties[propertyName] = virtualValue changedProperties[propertyName] = virtualValue
end end
else else
Log.warn("Failed to decode property of type {}", virtualValue.Type) -- virtualValue can be empty in certain cases, and this may print out nil to the user.
local propertyType = next(virtualValue)
Log.warn("Failed to decode property of type {}", propertyType)
end end
else else
local err = existingValueOrErr local err = existingValueOrErr