hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-24 15:01:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Update .gitmodules for rbx-dom URL and enhance UnresolvedValue handling

Browse source 
- Changed the rbx-dom submodule URL in .gitmodules from SSH to HTTPS for easier access.
- Introduced a new method to handle OptionalCFrame variants in UnresolvedValue, allowing for better serialization by returning `None` for `OptionalCFrame(None)`.
- Updated various files to utilize the new handling logic, ensuring properties are only inserted when resolved values are available.
This commit is contained in:
Joe 2026-01-21 16:07:24 -06:00
parent 4ccef46540
commit 69774fd546
6 changed files with 55 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/snapshot_middleware/json_model.rs
View file

@ -123,10 +123,11 @@ fn json_model_from_pair<'sync>(
}
}
_ => {
properties.insert(
name,
UnresolvedValue::from_variant(value.clone(), &new_inst.class, &name),
);
if let Some(resolved) =
UnresolvedValue::from_variant(value.clone(), &new_inst.class, &name)
{
properties.insert(name, resolved);
}
}
}
}

18
src/snapshot_middleware/meta_file.rs
View file

@ -147,10 +147,11 @@ impl AdjacentMetadata {
}
}
_ => {
properties.insert(
name,
UnresolvedValue::from_variant(value.clone(), class, &name),
);
if let Some(resolved) =
UnresolvedValue::from_variant(value.clone(), class, &name)
{
properties.insert(name, resolved);
}
}
}
}
@ -375,10 +376,11 @@ impl DirectoryMetadata {
}
}
_ => {
properties.insert(
name,
UnresolvedValue::from_variant(value.clone(), class, &name),
);
if let Some(resolved) =
UnresolvedValue::from_variant(value.clone(), class, &name)
{
properties.insert(name, resolved);
}
}
}
}

9
src/snapshot_middleware/project.rs
View file

@ -573,10 +573,11 @@ fn project_node_property_syncback(
}
}
_ => {
properties.insert(
name,
UnresolvedValue::from_variant(value.clone(), &new_inst.class, &name),
);
if let Some(resolved) =
UnresolvedValue::from_variant(value.clone(), &new_inst.class, &name)
{
properties.insert(name, resolved);
}
}
}
}