hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 14:01:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use history recording and don't do anything permanent (#915)

Browse source
This commit is contained in:
boatbomber 2024-05-30 12:28:58 -07:00 • committed by GitHub
parent 3d4e387d35
commit 62f4a1f3c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 59 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

45
plugin/src/Reconciler/applyPatch.spec.lua
View file

@ -4,25 +4,41 @@ return function()
local InstanceMap = require(script.Parent.Parent.InstanceMap)
local PatchSet = require(script.Parent.Parent.PatchSet)
local dummy = Instance.new("Folder")
local function wasDestroyed(instance)
local container = Instance.new("Folder")
local tempContainer = Instance.new("Folder")
local function wasRemoved(instance)
-- If an instance was destroyed, its parent property is locked.
local ok = pcall(function()
-- If an instance was removed, its parent property is nil.
-- We need to ensure we only remove, so that ChangeHistoryService can still Undo.
local isParentUnlocked = pcall(function()
local oldParent = instance.Parent
instance.Parent = dummy
instance.Parent = tempContainer
instance.Parent = oldParent
end)
return not ok
return instance.Parent == nil and isParentUnlocked
end
beforeEach(function()
container:ClearAllChildren()
end)
afterAll(function()
container:Destroy()
tempContainer:Destroy()
end)
it("should return an empty patch if given an empty patch", function()
local patch = applyPatch(InstanceMap.new(), PatchSet.newEmpty())
assert(PatchSet.isEmpty(patch), "expected remaining patch to be empty")
end)
it("should destroy instances listed for remove", function()
it("should remove instances listed for remove", function()
local root = Instance.new("Folder")
root.Name = "ROOT"
root.Parent = container
local child = Instance.new("Folder")
child.Name = "Child"
@ -38,14 +54,16 @@ return function()
local unapplied = applyPatch(instanceMap, patch)
assert(PatchSet.isEmpty(unapplied), "expected remaining patch to be empty")
assert(not wasDestroyed(root), "expected root to be left alone")
assert(wasDestroyed(child), "expected child to be destroyed")
assert(not wasRemoved(root), "expected root to be left alone")
assert(wasRemoved(child), "expected child to be removed")
instanceMap:stop()
end)
it("should destroy IDs listed for remove", function()
it("should remove IDs listed for remove", function()
local root = Instance.new("Folder")
root.Name = "ROOT"
root.Parent = container
local child = Instance.new("Folder")
child.Name = "Child"
@ -62,8 +80,8 @@ return function()
assert(PatchSet.isEmpty(unapplied), "expected remaining patch to be empty")
expect(instanceMap:size()).to.equal(1)
assert(not wasDestroyed(root), "expected root to be left alone")
assert(wasDestroyed(child), "expected child to be destroyed")
assert(not wasRemoved(root), "expected root to be left alone")
assert(wasRemoved(child), "expected child to be removed")
instanceMap:stop()
end)
@ -73,6 +91,8 @@ return function()
-- tests on reify, not here.
local root = Instance.new("Folder")
root.Name = "ROOT"
root.Parent = container
local instanceMap = InstanceMap.new()
instanceMap:insert("ROOT", root)
@ -113,6 +133,8 @@ return function()
it("should return unapplied additions when instances cannot be created", function()
local root = Instance.new("Folder")
root.Name = "ROOT"
root.Parent = container
local instanceMap = InstanceMap.new()
instanceMap:insert("ROOT", root)
@ -159,6 +181,7 @@ return function()
it("should recreate instances when changedClassName is set, preserving children", function()
local root = Instance.new("Folder")
root.Name = "Initial Root Name"
root.Parent = container
local child = Instance.new("Folder")
child.Name = "Child"