hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 05:51:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Enhance error handling in metadata file operations

Browse source 
- Added calls to `unsuppress_path` in various error handling scenarios within the `JobThreadContext` to ensure paths are correctly managed when file operations fail.
- Improved logging for failed write and serialization attempts, providing clearer feedback on issues encountered during metadata file processing.
This commit is contained in:
Joe 2026-02-10 17:10:45 -06:00
parent f496bee347
commit 5a5e1a0c77
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/change_processor.rs
View file

@ -249,6 +249,7 @@ impl JobThreadContext {
match crate::json::to_vec_pretty_sorted(&serde_json::Value::Object(obj)) {
Ok(content) => {
if let Err(err) = fs::write(meta_path, &content) {
self.unsuppress_path(meta_path);
log::error!(
"Failed to write name to meta file {}: {}",
meta_path.display(),
@ -257,6 +258,7 @@ impl JobThreadContext {
}
}
Err(err) => {
self.unsuppress_path(meta_path);
log::error!("Failed to serialize meta for name field: {}", err);
}
}
@ -285,6 +287,7 @@ impl JobThreadContext {
// Meta file only had the name field; delete it entirely
self.suppress_path_any(meta_path);
if let Err(err) = fs::remove_file(meta_path) {
self.unsuppress_path_any(meta_path);
log::error!(
"Failed to remove empty meta file {}: {}",
meta_path.display(),
@ -296,10 +299,12 @@ impl JobThreadContext {
match crate::json::to_vec_pretty_sorted(&serde_json::Value::Object(obj)) {
Ok(content) => {
if let Err(err) = fs::write(meta_path, &content) {
self.unsuppress_path(meta_path);
log::error!("Failed to write meta file {}: {}", meta_path.display(), err);
}
}
Err(err) => {
self.unsuppress_path(meta_path);
log::error!("Failed to serialize meta: {}", err);
}
}