Fix

Avoid sending spurious changedMetadata updates during sync

Closes #743

rojo-test/serve-test-snapshots/end_to_end__tests__serve__changed_metadata_metadata_only.snap

@@ -0,0 +1,18 @@
+---
+source: tests/tests/serve.rs
+expression: "packet.intern_and_redact(&mut redactions, ())"
+---
+body:
+  messageCursor: 2
+  messages:
+    - added: {}
+      removed: []
+      updated:
+        - changedClassName: ~
+          changedMetadata:
+            ignoreUnknownInstances: false
+          changedName: ~
+          changedProperties: {}
+          id: id-3
+packetType: messages
+sessionId: id-1

rojo-test/serve-test-snapshots/end_to_end__tests__serve__changed_metadata_property_and_metadata.snap

@@ -0,0 +1,20 @@
+---
+source: tests/tests/serve.rs
+expression: "packet.intern_and_redact(&mut redactions, ())"
+---
+body:
+  messageCursor: 3
+  messages:
+    - added: {}
+      removed: []
+      updated:
+        - changedClassName: ~
+          changedMetadata:
+            ignoreUnknownInstances: true
+          changedName: ~
+          changedProperties:
+            Anchored:
+              Bool: true
+          id: id-3
+packetType: messages
+sessionId: id-1

rojo-test/serve-test-snapshots/end_to_end__tests__serve__changed_metadata_property_only.snap

@@ -0,0 +1,19 @@
+---
+source: tests/tests/serve.rs
+expression: "packet.intern_and_redact(&mut redactions, ())"
+---
+body:
+  messageCursor: 1
+  messages:
+    - added: {}
+      removed: []
+      updated:
+        - changedClassName: ~
+          changedMetadata: ~
+          changedName: ~
+          changedProperties:
+            Anchored:
+              Bool: false
+          id: id-3
+packetType: messages
+sessionId: id-1

rojo-test/serve-test-snapshots/end_to_end__tests__serve__changed_metadata_relevant_paths_only.snap

@@ -0,0 +1,12 @@
+---
+source: tests/tests/serve.rs
+expression: "packet.intern_and_redact(&mut redactions, ())"
+---
+body:
+  messageCursor: 4
+  messages:
+    - added: {}
+      removed: []
+      updated: []
+packetType: messages
+sessionId: id-1

rojo-test/serve-test-snapshots/end_to_end__tests__serve__model_pivot_migration_all.snap

@@ -18,12 +18,6 @@ body:
             NeedsPivotMigration:
               Bool: false
       removed: []
-      updated:
-        - changedClassName: ~
-          changedMetadata:
-            ignoreUnknownInstances: true
-          changedName: ~
-          changedProperties: {}
-          id: id-3
+      updated: []
 packetType: messages
 sessionId: id-1

rojo-test/serve-test-snapshots/end_to_end__tests__serve__ref_properties_subscribe.snap

@@ -26,8 +26,7 @@ body:
       removed: []
       updated:
         - changedClassName: ~
-          changedMetadata:
-            ignoreUnknownInstances: false
+          changedMetadata: ~
           changedName: ~
           changedProperties:
             Attributes:

rojo-test/serve-tests/changed_metadata/a/mod.lua

@@ -0,0 +1 @@
+-- shared contents

rojo-test/serve-tests/changed_metadata/b/mod.lua

@@ -0,0 +1 @@
+-- shared contents

rojo-test/serve-tests/changed_metadata/default.project.json

@@ -0,0 +1,18 @@
+{
+  "name": "changed_metadata",
+  "tree": {
+    "$className": "DataModel",
+    "Workspace": {
+      "$className": "Workspace",
+      "Baseplate": {
+        "$className": "Part",
+        "$properties": {
+          "Anchored": true
+        }
+      },
+      "Thing": {
+        "$path": "a"
+      }
+    }
+  }
+}