From 38cbc582f40b97aa9c909e3a75535d92d4a740f9 Mon Sep 17 00:00:00 2001 From: Joe Date: Fri, 30 Jan 2026 10:18:45 -0600 Subject: [PATCH] Update default behavior of ignore_hidden_services in SyncbackRules - Changed the default value of the `ignore_hidden_services` option from `false` to `true` to ensure that only visible services are synced back by default. - Updated related documentation and comments to reflect the new default behavior and clarify the filtering logic in the syncback loop. --- src/syncback/mod.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/syncback/mod.rs b/src/syncback/mod.rs index c76ba5a1..a536fff5 100644 --- a/src/syncback/mod.rs +++ b/src/syncback/mod.rs @@ -111,12 +111,12 @@ pub fn syncback_loop( strip_unknown_root_children(&mut new_tree, old_tree); } - // If ignoreHiddenServices is enabled, filter to only visible services + // If ignoreHiddenServices is enabled (default: true), filter to only visible services if project .syncback_rules .as_ref() .map(|rules| rules.ignore_hidden_services()) - .unwrap_or(false) + .unwrap_or(true) { log::debug!("Filtering hidden services"); strip_hidden_services(&mut new_tree); @@ -442,7 +442,7 @@ pub struct SyncbackRules { /// When enabled, only "visible" services will be synced back. This includes /// commonly used services like Workspace, ReplicatedStorage, ServerScriptService, /// etc., while ignoring internal/hidden services like Chat, HttpService, etc. - /// Defaults to `false`. + /// Defaults to `true`. #[serde(skip_serializing_if = "Option::is_none")] ignore_hidden_services: Option, } @@ -493,10 +493,10 @@ impl SyncbackRules { /// Returns whether hidden/internal services should be ignored during /// syncback. When `true`, only visible services like Workspace, - /// ReplicatedStorage, etc. will be synced. Defaults to `false`. + /// ReplicatedStorage, etc. will be synced. Defaults to `true`. #[inline] pub fn ignore_hidden_services(&self) -> bool { - self.ignore_hidden_services.unwrap_or(false) + self.ignore_hidden_services.unwrap_or(true) } }