hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-22 21:41:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: tighten stress_rename_operations assertion to check relevant paths

Browse source 
Bugbot flagged `has_create || has_remove || !events.is_empty()` as
trivially true. Replace with a check that at least one event references
either the original or renamed path, regardless of event type (FSEvents
on macOS reports renames as Write/Metadata, not always Create/Remove).
This commit is contained in:
Joe 2026-03-12 20:27:08 -05:00
parent 22808e6140
commit 361b4a30ec
1 changed files with 10 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
crates/memofs/src/std_backend.rs
View file

@ -866,17 +866,18 @@ mod tests {
// Should get either: // Should get either:
// - Remove(original) + Create(renamed) for RenameMode::Both // - Remove(original) + Create(renamed) for RenameMode::Both
// - Or separate From/To events // - Or separate From/To events
let has_remove = events // FSEvents on macOS may report renames as Write/Metadata events rather
.iter() // than the specific Create/Remove pair. Verify that at least one event
.any(|e| matches!(e, VfsEvent::Remove(p) if p == &original)); // references either the original or renamed path.
let has_create = events let has_relevant_event = events.iter().any(|e| match e {
.iter() VfsEvent::Create(p) | VfsEvent::Write(p) | VfsEvent::Remove(p) => {
.any(|e| matches!(e, VfsEvent::Create(p) if p == &renamed)); p == &original || p == &renamed
}
});
// At minimum we should see the new file appear
assert!( assert!(
has_create || has_remove || !events.is_empty(), has_relevant_event,
"Expected rename to generate events (got {} events: {:?})", "Expected rename to generate events for original or renamed path (got {} events: {:?})",
events.len(), events.len(),
events events
); );