hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 05:51:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix syncback process to handle directory paths and class transitions in clean mode

Browse source 
- Resolved an issue where syncback failed for projects with `$path` pointing to single files by ensuring only directory paths are scanned for orphans.
- Implemented a function to create missing directories in clean mode, allowing restoration of deleted directories.
- Enhanced class transition handling in clean mode to allow recoverable transitions between Folder and Script types.
- Updated logging and error handling to improve clarity during the syncback process.
This commit is contained in:
Joe 2026-02-01 19:27:53 -06:00
parent fe1ac1dd95
commit 2e6f909a71
5 changed files with 194 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

27
.cursor/plans/syncback_roundtrip_tests_f980a65b.plan.md
View file

@ -94,13 +94,34 @@ This skipped ANY file whose parent directory was in `added_paths`, but adding a
**Affected tests**: `clean_removes_duplicate_extensions`, `clean_removes_multiple_duplicates`
### Bug 5: File Paths Added to Directory Scan (FIXED)
**Symptom**: Projects with `$path` pointing to single files (not directories) were failing syncback.
**Root cause**: The `collect_paths_from_project` function was adding all `$path` entries to the scan list, but only directories should be scanned for orphans.
**Fix applied**: Changed to only add `$path` entries that are directories (`resolved.is_dir()`).
---
## Test Results Summary (Current)
## Test Results Summary (Final)
**Passing: 15 tests** - orphan removal, basic clean mode behavior
**Full test suite: 179 passed, 16 failed**
**Failing: 11 tests** - class change scenarios, ambiguous files, meta files, combination tests
**Clean Mode Stress Tests: 15 passed, 11 failed**
- Passing: All orphan removal tests, basic clean mode behavior
- Failing: Class change scenarios (3), ambiguous files (2), meta/extension issues (3), combination tests (3)
**Pre-existing Failures (not from this work): 5 tests**
- `syncback_roundtrip::infer_service_name`
- `syncback_roundtrip::init_meta_class_name`
- `syncback_roundtrip::init_meta_properties`
- `syncback_roundtrip::rbxmx_ref`
- `syncback::ignore_trees_removing`
These were failing before the current changes and are separate issues.
---