hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 14:01:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Allow openScriptsExternally option to be changed during sync (#911)

Browse source
This commit is contained in:
Micah 2024-05-08 12:34:00 -07:00 • committed by GitHub
parent 41443d3989
commit 2c46640105
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugin/src/ServeSession.lua
View file

@ -13,6 +13,7 @@ local InstanceMap = require(script.Parent.InstanceMap)
local PatchSet = require(script.Parent.PatchSet)
local Reconciler = require(script.Parent.Reconciler)
local strict = require(script.Parent.strict)
local Settings = require(script.Parent.Settings)
local Status = strict("Session.Status", {
NotStarted = "NotStarted",
@ -50,7 +51,6 @@ ServeSession.Status = Status
local validateServeOptions = t.strictInterface({
apiContext = t.table,
openScriptsExternally = t.boolean,
twoWaySync = t.boolean,
})
@ -89,7 +89,6 @@ function ServeSession.new(options)
self = {
__status = Status.NotStarted,
__apiContext = options.apiContext,
__openScriptsExternally = options.openScriptsExternally,
__twoWaySync = options.twoWaySync,
__reconciler = reconciler,
__instanceMap = instanceMap,
@ -170,7 +169,7 @@ function ServeSession:__applyGameAndPlaceId(serverInfo)
end
function ServeSession:__onActiveScriptChanged(activeScript)
if not self.__openScriptsExternally then
if not Settings:get("openScriptsExternally") then
Log.trace("Not opening script {} because feature not enabled.", activeScript)
return