hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 05:51:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve logging performance by conditionally checking trace level

Browse source 
- Introduced a new `isTraceEnabled` function in the logging module to check if trace logging is enabled based on the current log level.
- Updated the `performRequest` function to only log HTTP request details and responses if trace logging is enabled, reducing unnecessary log output and improving performance.

These changes aim to enhance the efficiency of logging during HTTP requests by avoiding excessive logging when not needed.
This commit is contained in:
Joe 2026-03-01 16:43:21 -06:00
parent 33022667dc
commit 25ca0bb27e
2 changed files with 15 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

17
plugin/http/init.lua
View file

@ -18,10 +18,11 @@ local function performRequest(requestParams)
local requestId = lastRequestId + 1 local requestId = lastRequestId + 1
lastRequestId = requestId lastRequestId = requestId
Log.trace("HTTP {}({}) {}", requestParams.Method, requestId, requestParams.Url) if Log.isTraceEnabled() then
Log.trace("HTTP {}({}) {}", requestParams.Method, requestId, requestParams.Url)
if requestParams.Body ~= nil then if requestParams.Body ~= nil then
Log.trace("{}", requestParams.Body) Log.trace("{}", requestParams.Body)
end
end end
return Promise.new(function(resolve, reject) return Promise.new(function(resolve, reject)
@ -31,7 +32,9 @@ local function performRequest(requestParams)
end) end)
if success then if success then
Log.trace("Request {} success, response {:#?}", requestId, response) if Log.isTraceEnabled() then
Log.trace("Request {} success, response {:#?}", requestId, response)
end
local httpResponse = HttpResponse.fromRobloxResponse(response) local httpResponse = HttpResponse.fromRobloxResponse(response)
if httpResponse:isSuccess() then if httpResponse:isSuccess() then
resolve(httpResponse) resolve(httpResponse)
@ -39,7 +42,9 @@ local function performRequest(requestParams)
reject(HttpError.fromResponse(httpResponse)) reject(HttpError.fromResponse(httpResponse))
end end
else else
Log.trace("Request {} failure: {:?}", requestId, response) if Log.isTraceEnabled() then
Log.trace("Request {} failure: {:?}", requestId, response)
end
reject(HttpError.fromRobloxErrorString(response)) reject(HttpError.fromRobloxErrorString(response))
end end
end)() end)()

4
plugin/log/init.lua
View file

@ -29,6 +29,10 @@ function Log.setLogLevelThunk(thunk)
getLogLevel = thunk getLogLevel = thunk
end end
function Log.isTraceEnabled()
return getLogLevel() >= Level.Trace
end
function Log.trace(template, ...) function Log.trace(template, ...)
if getLogLevel() >= Level.Trace then if getLogLevel() >= Level.Trace then
print(addTags(TRACE_TAG, Fmt.fmt(template, ...))) print(addTags(TRACE_TAG, Fmt.fmt(template, ...)))