From 240c225be08c121ea405fe71bf4d693e894ee263 Mon Sep 17 00:00:00 2001 From: Joe Date: Fri, 30 Jan 2026 11:18:00 -0600 Subject: [PATCH] Refactor PullAll button logic in Confirming.lua for improved readability - Removed conditional rendering of the PullAll button based on settings and simplified its implementation. - Enhanced the overall structure of the button definition for better clarity in the ConfirmingPage render function. --- plugin/src/App/StatusPages/Confirming.lua | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/plugin/src/App/StatusPages/Confirming.lua b/plugin/src/App/StatusPages/Confirming.lua index 8ff3872d..7819ab54 100644 --- a/plugin/src/App/StatusPages/Confirming.lua +++ b/plugin/src/App/StatusPages/Confirming.lua @@ -4,7 +4,6 @@ local Packages = Rojo.Packages local Roact = require(Packages.Roact) -local Settings = require(Plugin.Settings) local Theme = require(Plugin.App.Theme) local PatchTree = require(Plugin.PatchTree) local TextButton = require(Plugin.App.Components.TextButton) @@ -154,17 +153,15 @@ function ConfirmingPage:render() onClick = self.props.onAbort, }), - PullAll = if Settings:get("twoWaySync") - then e(TextButton, { - text = "Pull All", - style = "Danger", - transparency = self.props.transparency, - layoutOrder = 2, - onClick = function() - self.setAllSelections("pull") - end, - }) - else nil, + PullAll = e(TextButton, { + text = "Pull All", + style = "Danger", + transparency = self.props.transparency, + layoutOrder = 2, + onClick = function() + self.setAllSelections("pull") + end, + }), SkipAll = e(TextButton, { text = "Skip All",