Stop serializing project_node if it's None

2026-10-20 17:41:37 +00:00 · 2019-10-04 15:12:21 -07:00 · 2019-10-04 15:12:21 -07:00 · 238233ca81
commit 238233ca81
parent 938c8259c3
22 changed files with 1 additions and 25 deletions
--- a/src/snapshot/metadata.rs
+++ b/src/snapshot/metadata.rs
@ -45,6 +45,7 @@ pub struct InstanceMetadata {
    /// This information is used to make sure the instance has the correct name,
    /// project-added children, and metadata when it's updated in response to a
    /// file change.
+    #[serde(skip_serializing_if = "Option::is_none")]
    pub project_node: Option<(String, ProjectNode)>,
 }

--- a/src/snapshot/tests/snapshots/apply__add_property.snap
+++ b/src/snapshot/tests/snapshots/apply__add_property.snap
@ -12,5 +12,4 @@ properties:
 metadata:
  ignore_unknown_instances: false
  contributing_paths: []
-  project_node: ~
 children: []
--- a/src/snapshot/tests/snapshots/apply__remove_property_initial.snap
+++ b/src/snapshot/tests/snapshots/apply__remove_property_initial.snap
@ -12,5 +12,4 @@ properties:
 metadata:
  ignore_unknown_instances: false
  contributing_paths: []
-  project_node: ~
 children: []
--- a/src/snapshot/tests/snapshots/apply__set_name_and_class_name.snap
+++ b/src/snapshot/tests/snapshots/apply__set_name_and_class_name.snap
@ -9,5 +9,4 @@ properties: {}
 metadata:
  ignore_unknown_instances: false
  contributing_paths: []
-  project_node: ~
 children: []
--- a/src/snapshot/tests/snapshots/compute__add_child.snap
+++ b/src/snapshot/tests/snapshots/compute__add_child.snap
@ -10,7 +10,6 @@ added_instances:
      metadata:
        ignore_unknown_instances: false
        contributing_paths: []
-        project_node: ~
      name: New
      class_name: Folder
      properties: {}
--- a/src/snapshot_middleware/snapshots/test__client_from_imfs.snap
+++ b/src/snapshot_middleware/snapshots/test__client_from_imfs.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: false
  contributing_paths:
    - /foo.client.lua
-  project_node: ~
 name: foo
 class_name: LocalScript
 properties:
--- a/src/snapshot_middleware/snapshots/test__csv_from_imfs.snap
+++ b/src/snapshot_middleware/snapshots/test__csv_from_imfs.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: false
  contributing_paths:
    - /foo.csv
-  project_node: ~
 name: foo
 class_name: LocalizationTable
 properties:
--- a/src/snapshot_middleware/snapshots/test__empty_folder.snap
+++ b/src/snapshot_middleware/snapshots/test__empty_folder.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: false
  contributing_paths:
    - /foo
-  project_node: ~
 name: foo
 class_name: Folder
 properties: {}
--- a/src/snapshot_middleware/snapshots/test__folder_in_folder.snap
+++ b/src/snapshot_middleware/snapshots/test__folder_in_folder.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: false
  contributing_paths:
    - /foo
-  project_node: ~
 name: foo
 class_name: Folder
 properties: {}
@ -17,7 +16,6 @@ children:
      ignore_unknown_instances: false
      contributing_paths:
        - /foo/Child
-      project_node: ~
    name: Child
    class_name: Folder
    properties: {}
--- a/src/snapshot_middleware/snapshots/test__instance_from_imfs.snap
+++ b/src/snapshot_middleware/snapshots/test__instance_from_imfs.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: false
  contributing_paths:
    - /foo.txt
-  project_node: ~
 name: foo
 class_name: StringValue
 properties:
--- a/src/snapshot_middleware/snapshots/test__model_from_imfs.snap
+++ b/src/snapshot_middleware/snapshots/test__model_from_imfs.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: false
  contributing_paths:
    - /foo.model.json
-  project_node: ~
 name: foo
 class_name: IntValue
 properties:
@ -19,7 +18,6 @@ children:
    metadata:
      ignore_unknown_instances: false
      contributing_paths: []
-      project_node: ~
    name: The Child
    class_name: StringValue
    properties: {}
--- a/src/snapshot_middleware/snapshots/test__module_from_imfs.snap
+++ b/src/snapshot_middleware/snapshots/test__module_from_imfs.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: false
  contributing_paths:
    - /foo.lua
-  project_node: ~
 name: foo
 class_name: ModuleScript
 properties:
--- a/src/snapshot_middleware/snapshots/test__project_from_direct_file.snap
+++ b/src/snapshot_middleware/snapshots/test__project_from_direct_file.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: true
  contributing_paths:
    - /foo/hello.project.json
-  project_node: ~
 name: direct-project
 class_name: Model
 properties: {}
--- a/src/snapshot_middleware/snapshots/test__project_from_folder.snap
+++ b/src/snapshot_middleware/snapshots/test__project_from_folder.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: true
  contributing_paths:
    - /foo/default.project.json
-  project_node: ~
 name: indirect-project
 class_name: Folder
 properties: {}
--- a/src/snapshot_middleware/snapshots/test__project_path_property_overrides.snap
+++ b/src/snapshot_middleware/snapshots/test__project_path_property_overrides.snap
@ -8,7 +8,6 @@ metadata:
  contributing_paths:
    - /foo/default.project.json
    - /foo/other.project.json
-  project_node: ~
 name: path-property-override
 class_name: StringValue
 properties:
--- a/src/snapshot_middleware/snapshots/test__project_with_children.snap
+++ b/src/snapshot_middleware/snapshots/test__project_with_children.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: true
  contributing_paths:
    - /foo/default.project.json
-  project_node: ~
 name: children
 class_name: Folder
 properties: {}
@ -16,7 +15,6 @@ children:
    metadata:
      ignore_unknown_instances: true
      contributing_paths: []
-      project_node: ~
    name: Child
    class_name: Model
    properties: {}
--- a/src/snapshot_middleware/snapshots/test__project_with_path_to_project.snap
+++ b/src/snapshot_middleware/snapshots/test__project_with_path_to_project.snap
@ -8,7 +8,6 @@ metadata:
  contributing_paths:
    - /foo/default.project.json
    - /foo/other.project.json
-  project_node: ~
 name: path-project
 class_name: Model
 properties: {}
--- a/src/snapshot_middleware/snapshots/test__project_with_path_to_project_with_children.snap
+++ b/src/snapshot_middleware/snapshots/test__project_with_path_to_project_with_children.snap
@ -8,7 +8,6 @@ metadata:
  contributing_paths:
    - /foo/default.project.json
    - /foo/other.project.json
-  project_node: ~
 name: path-child-project
 class_name: Folder
 properties: {}
@ -17,7 +16,6 @@ children:
    metadata:
      ignore_unknown_instances: true
      contributing_paths: []
-      project_node: ~
    name: SomeChild
    class_name: Model
    properties: {}
--- a/src/snapshot_middleware/snapshots/test__project_with_path_to_txt.snap
+++ b/src/snapshot_middleware/snapshots/test__project_with_path_to_txt.snap
@ -8,7 +8,6 @@ metadata:
  contributing_paths:
    - /foo/default.project.json
    - /foo/other.txt
-  project_node: ~
 name: path-project
 class_name: StringValue
 properties:
--- a/src/snapshot_middleware/snapshots/test__project_with_resolved_properties.snap
+++ b/src/snapshot_middleware/snapshots/test__project_with_resolved_properties.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: true
  contributing_paths:
    - /foo/default.project.json
-  project_node: ~
 name: resolved-properties
 class_name: StringValue
 properties:
--- a/src/snapshot_middleware/snapshots/test__project_with_unresolved_properties.snap
+++ b/src/snapshot_middleware/snapshots/test__project_with_unresolved_properties.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: true
  contributing_paths:
    - /foo/default.project.json
-  project_node: ~
 name: unresolved-properties
 class_name: StringValue
 properties:
--- a/src/snapshot_middleware/snapshots/test__server_from_imfs.snap
+++ b/src/snapshot_middleware/snapshots/test__server_from_imfs.snap
@ -7,7 +7,6 @@ metadata:
  ignore_unknown_instances: false
  contributing_paths:
    - /foo.server.lua
-  project_node: ~
 name: foo
 class_name: Script
 properties: