hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-21 12:01:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Return 400 for missing /api/serialize IDs (#1272)

Browse source
This commit is contained in:
AK-Khan02 2026-06-10 21:48:33 -04:00 • committed by GitHub
parent d12120bab6
commit 16633e3c65
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 37 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

36
tests/tests/serve.rs
View file

@ -1,14 +1,16 @@
use std::fs;
use insta::{assert_snapshot, assert_yaml_snapshot, with_settings};
use rbx_dom_weak::types::Ref;
use reqwest::StatusCode;
use tempfile::tempdir;
use crate::rojo_test::{
internable::InternAndRedact,
serve_util::{run_serve_test, serialize_to_xml_model},
serve_util::{deserialize_msgpack, run_serve_test, serialize_to_xml_model},
};
use librojo::web_api::SocketPacketType;
use librojo::web_api::{SerializeResponse, SocketPacketType};
#[test]
fn rejects_dns_rebinding_requests() {
@ -713,9 +715,13 @@ fn meshpart_with_id() {
.find(|(_, inst)| inst.class_name == "ObjectValue")
.unwrap();
let serialize_response = session
.get_api_serialize(&[*meshpart, *objectvalue], info.session_id)
let body = session
.post_api_serialize(&[*meshpart, *objectvalue], info.session_id)
.unwrap()
.bytes()
.unwrap();
let serialize_response: SerializeResponse =
deserialize_msgpack(&body).expect("Server returned malformed response");
// We don't assert a snapshot on the SerializeResponse because the model includes the
// Refs from the DOM as names, which means it will obviously be different every time
@ -727,6 +733,20 @@ fn meshpart_with_id() {
});
}
#[test]
fn serialize_missing_id() {
run_serve_test("empty", |session, _| {
let info = session.get_api_rojo().unwrap();
let missing_id = Ref::new();
let response = session
.post_api_serialize(&[missing_id], info.session_id)
.unwrap();
assert_eq!(response.status(), StatusCode::BAD_REQUEST);
});
}
#[test]
fn forced_parent() {
run_serve_test("forced_parent", |session, mut redactions| {
@ -741,9 +761,13 @@ fn forced_parent() {
read_response.intern_and_redact(&mut redactions, root_id)
);
let serialize_response = session
.get_api_serialize(&[root_id], info.session_id)
let body = session
.post_api_serialize(&[root_id], info.session_id)
.unwrap()
.bytes()
.unwrap();
let serialize_response: SerializeResponse =
deserialize_msgpack(&body).expect("Server returned malformed response");
assert_eq!(serialize_response.session_id, info.session_id);