hakowork/rojo
3
0
Fork 0
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-10-23 05:51:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor syncback process to improve clean mode handling and directory management

Browse source 
- Removed the ensure_project_paths_exist function, streamlining the syncback process by directly managing directory creation and cleanup within the syncback command.
- Enhanced error handling for sourcemap generation, logging warnings when clean mode removes directories that only contain meta files.
- Updated the logic for middleware selection in clean mode to better handle directory and script transitions based on the filesystem structure.
- Added utility functions to ensure base project directories exist before syncback, addressing the need for directory structure in clean mode.
- Improved test coverage for clean mode scenarios, ensuring that directory existence checks are performed and documented.
This commit is contained in:
Joe 2026-02-01 19:55:54 -06:00
parent 1f476d6cc9
commit 1534a54808
6 changed files with 229 additions and 104 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/syncback/mod.rs
View file

@ -589,19 +589,16 @@ pub fn syncback_loop_with_stats(
for old_path in &existing_paths {
let old_path_norm = normalize_existing_path(old_path);
// Never remove the project file itself
// Never remove the ROOT project file itself
if old_path_norm == project_file {
log::trace!("Skipping project file: {}", old_path.display());
log::trace!("Skipping root project file: {}", old_path.display());
continue;
}
// Never remove any nested project files - they define project structure
// and may be referenced via $path from other project files
if let Some(file_name) = old_path_norm.file_name().and_then(|n| n.to_str()) {
if file_name.ends_with(".project.json5") || file_name.ends_with(".project.json") {
log::trace!("Skipping nested project file: {}", old_path.display());
continue;
}
}
// In clean mode, orphan nested project files ARE removed.
// Clean mode represents "delete everything and rebuild from rbxm" -
// orphan project files that aren't referenced by the main project
// should not survive. Only the root project file is protected.
//
// Skip if this exact path is being written to
if added_paths.contains(&old_path_norm) {
log::trace!("Skipping {} (exact path in added_paths)", old_path.display());