Enhance instance metadata and reconciliation logic for glob-ignored children

- Added `globIgnoredChildren` to `ApiInstanceMetadata` to manage child deletion behavior based on glob patterns.
- Updated `shouldDeleteChild` function to suppress deletions when `globIgnoredChildren` is true, differentiating from scripts-only mode.
- Enhanced tests to verify correct behavior of instance deletion based on the new metadata, ensuring robust handling of unknown scripts.
- Refactored snapshot handling to incorporate `globIgnoredChildren` in metadata, improving clarity and maintainability.

src/snapshot_middleware/dir.rs

@@ -118,7 +118,8 @@ pub fn snapshot_dir_no_meta(
                 .instigating_source(path)
                 .relevant_paths(relevant_paths)
                 .context(context)
-                .ignore_unknown_instances(any_child_glob_ignored),
+                .ignore_unknown_instances(any_child_glob_ignored)
+                .glob_ignored_children(any_child_glob_ignored),
         );
 
     Ok(Some(snapshot))
@@ -602,6 +603,10 @@ mod test {
             snap.metadata.ignore_unknown_instances,
             "Directory with glob-ignored children should have ignore_unknown_instances = true"
         );
+        assert!(
+            snap.metadata.glob_ignored_children,
+            "Directory with glob-ignored children should have glob_ignored_children = true"
+        );
         assert_eq!(
             snap.children.len(),
             1,
@@ -636,6 +641,10 @@ mod test {
             !snap.metadata.ignore_unknown_instances,
             "Directory without glob-ignored children should have ignore_unknown_instances = false"
         );
+        assert!(
+            !snap.metadata.glob_ignored_children,
+            "Directory without glob-ignored children should have glob_ignored_children = false"
+        );
         assert_eq!(snap.children.len(), 2);
     }
 }

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__csv__test__csv_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.csv
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__csv__test__csv_init.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /root/init.csv
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__csv__test__csv_init_with_meta.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /root/init.csv
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__csv__test__csv_with_meta.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.csv
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__dir__test__empty_folder.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__dir__test__folder_in_folder.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo
   relevant_paths:
@@ -30,6 +31,7 @@ children:
   - snapshot_id: "00000000000000000000000000000000"
     metadata:
       ignore_unknown_instances: false
+      glob_ignored_children: false
       instigating_source:
         Path: /foo/Child
       relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__json__test__instance_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__json__test__with_metadata.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__json_model__test__model_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.model.json5
   relevant_paths:
@@ -22,6 +23,7 @@ children:
   - snapshot_id: "00000000000000000000000000000000"
     metadata:
       ignore_unknown_instances: false
+      glob_ignored_children: false
       relevant_paths: []
       context: {}
       specified_id: ~

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__json_model__test__model_from_vfs_legacy.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.model.json5
   relevant_paths:
@@ -22,6 +23,7 @@ children:
   - snapshot_id: "00000000000000000000000000000000"
     metadata:
       ignore_unknown_instances: false
+      glob_ignored_children: false
       relevant_paths: []
       context: {}
       specified_id: ~

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__client_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.client.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__init_module_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /root/init.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__init_module_from_vfs_with_meta.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /root/init.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__legacy_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.legacy.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__local_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.local.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__module_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__module_with_meta.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__plugin_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.plugin.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__server_disabled.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /bar.server.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__server_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.server.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__lua__test__server_with_meta.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.server.luau
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__meta_file__test__adjacent_read_json5.snap

@@ -5,6 +5,7 @@ expression: snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   relevant_paths:
     - /foo/bar.meta.json5
   context: {}

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__meta_file__test__directory_read_json5.snap

@@ -5,6 +5,7 @@ expression: snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   relevant_paths:
     - /foo/init.meta.json5
   context: {}

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__no_name_project.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo/default.project.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__project_from_direct_file.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo/hello.project.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__project_path_property_overrides.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo/default.project.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__project_with_children.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.project.json5
   relevant_paths:
@@ -20,6 +21,7 @@ children:
   - snapshot_id: "00000000000000000000000000000000"
     metadata:
       ignore_unknown_instances: true
+      glob_ignored_children: false
       instigating_source:
         ProjectNode:
           path: /foo.project.json5

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__project_with_path_to_project.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo/default.project.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__project_with_path_to_project_with_children.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo/default.project.json5
   relevant_paths:
@@ -21,6 +22,7 @@ children:
   - snapshot_id: "00000000000000000000000000000000"
     metadata:
       ignore_unknown_instances: true
+      glob_ignored_children: false
       instigating_source:
         ProjectNode:
           path: /foo/other.project.json5

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__project_with_path_to_txt.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo/default.project.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__project_with_resolved_properties.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.project.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__project__test__project_with_unresolved_properties.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: true
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.project.json5
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__toml__test__instance_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.toml
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__toml__test__with_metadata.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: foo.toml
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__txt__test__instance_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.txt
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__txt__test__with_metadata.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.txt
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__yaml__test__instance_from_vfs.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: /foo.yaml
   relevant_paths:

src/snapshot_middleware/snapshots/librojo__snapshot_middleware__yaml__test__with_metadata.snap

@@ -5,6 +5,7 @@ expression: instance_snapshot
 snapshot_id: "00000000000000000000000000000000"
 metadata:
   ignore_unknown_instances: false
+  glob_ignored_children: false
   instigating_source:
     Path: foo.yaml
   relevant_paths: