hakowork/charm
3
0
Fork 0
mirror of https://github.com/littensy/charm.git synced 2026-10-21 03:36:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: avoid reconnecting to dependencies after cleanup (#14)

Browse source 
* fix: cancel reconnection when unsubscribing

* test: remove print

* feat: allow factory to return nil

* perf: use `next` iteration
This commit is contained in:
richard 2024-07-10 15:13:36 -07:00 • committed by GitHub
parent 62be3e496d
commit c6762a6525
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
14 changed files with 87 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/subscribe.luau
View file

@ -12,22 +12,31 @@ type Molecule<T> = types.Molecule<T>
@return A function that unsubscribes the callback.
]=]
local function subscribe<T>(molecule: Molecule<T>, callback: (state: T, prev: T) -> ()): () -> ()
local captured, state = store.capture(molecule)
local dependencies, state = store.capture(molecule)
local disconnected = false
local function listener()
local prevState = state
captured, state = store.reconnect(molecule, captured, listener)
store.disconnect(dependencies, listener)
dependencies, state = store.capture(molecule)
if not disconnected then
store.connect(dependencies, listener)
end
if state ~= prevState then
callback(state, prevState)
end
end
store.connect(captured, listener)
store.connect(dependencies, listener)
return function()
store.disconnect(captured, listener)
if not disconnected then
disconnected = true
store.disconnect(dependencies, listener)
end
end
end