hakowork/charm
3
0
Fork 0
mirror of https://github.com/littensy/charm.git synced 2026-10-20 17:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: prevent early reactive gc, alien-signals 3.1.1

Browse source
This commit is contained in:
littensy 2025-11-28 20:36:51 -08:00
parent b826401bf3
commit 9d4af8e669
5 changed files with 94 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

24
packages/charm-sync/src/client.luau
View file

@ -8,7 +8,15 @@ type SyncPayload = types.SyncPayload
type Setter<T = any> = (T | (T) -> any) -> ()
local trackedSignals: { [string]: Setter } = {}
local trackedReactives: { [string]: Setter } = {}
local trackedReactives: { [string]: ReactiveProxy } = {}
local function shallowMergeReactive(reactive: ReactiveProxy, source: { [any]: any })
local target = reactive.__target
for key, value in source do
target[key] = value
end
Charm.trigger(reactive.__track)
end
--[[
Registers a map of setters to the state with the corresponding keys on the
@ -26,7 +34,7 @@ local function addSignals(signals: { [string]: Setter | {} })
if type(signal) == "function" then
trackedSignals[key] = signal
else
trackedReactives[key] = ((signal :: any) :: ReactiveProxy).__set
trackedReactives[key] = (signal :: any) :: ReactiveProxy
end
end
end
@ -54,9 +62,10 @@ end
local function applyInitPayload(data: { [string]: any })
for key, value in data do
local trackedSignal: Setter? = trackedSignals[key] or trackedReactives[key]
if trackedSignal then
trackedSignal(value)
if trackedSignals[key] then
trackedSignals[key](value)
elseif trackedReactives[key] then
shallowMergeReactive(trackedReactives[key], value)
end
end
end
@ -71,9 +80,8 @@ local function applyPatchPayload(data: { [string]: any })
return patch.apply(value, diffs)
end)
elseif trackedReactive then
trackedReactive(function(value): ()
patch.applyMutable(value, diffs)
end)
patch.applyMutable(trackedReactive.__target, diffs)
Charm.trigger(trackedReactive.__track)
end
end
end