hakowork/charm
3
0
Fork 0
mirror of https://github.com/littensy/charm.git synced 2026-10-20 17:51:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: check none before patching mutable tables

Browse source
This commit is contained in:
littensy 2025-11-22 22:03:42 -08:00
parent 189ae0f168
commit 422ee43a94
2 changed files with 19 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/charm-sync/src/__tests__/patch.spec.luau
View file

@ -127,4 +127,10 @@ test("patches mutable state", function()
assert(targetState.qaz == "qux", "should add the new value")
end)
test("removes table from mutable state", function()
local targetState = { foo = { bar = "baz" } }
patch.applyMutable(targetState, { foo = { __none = "__none" } })
assert(targetState.foo == nil, "should remove the table")
end)
return {}

12
packages/charm-sync/src/patch.luau
View file

@ -112,7 +112,12 @@ local function apply(oldState: any, diffs: any): any
end
local function applyMutable(targetState: any, sourceState: any): any
if type(targetState) == "table" and type(sourceState) == "table" then
if isNone(sourceState) then
return nil
elseif type(targetState) ~= "table" or type(sourceState) ~= "table" then
return sourceState
end
local targetIsArray = targetState[1] ~= nil
for key, value in sourceState do
@ -123,11 +128,6 @@ local function applyMutable(targetState: any, sourceState: any): any
end
return targetState
elseif isNone(sourceState) then
return nil
else
return sourceState
end
end
return {