From 29be66fa94523e4032aae44089aa8670cccec851 Mon Sep 17 00:00:00 2001 From: littensy <56808540+littensy@users.noreply.github.com> Date: Sat, 20 Jun 2026 21:16:14 -0700 Subject: [PATCH] test: add skipped inner effect dispose order test --- packages/charm/test/effect.test.luau | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/packages/charm/test/effect.test.luau b/packages/charm/test/effect.test.luau index c94ec51..17cd0a0 100644 --- a/packages/charm/test/effect.test.luau +++ b/packages/charm/test/effect.test.luau @@ -573,4 +573,21 @@ test.skip("should handle inner effect cleanup disposing outer effect", function( assert(#order == 0, "should not cleanup after dispose") end) +test.skip("should old inner effect dispose before outer effect re-runs", function() + local order: { string } = {} + local src, setSrc = signal(false) + effect(function() + src() + table.insert(order, "outer") + effect(function() + return function() + table.insert(order, "inner") + end + end) + end) + table.clear(order) + setSrc(true) + assert(table.concat(order) == "innerouter", `bad rerun order: {table.concat(order)}`) +end) + return {}