From 258fe1319130a68fc4490c5e41efd79f9eaad61b Mon Sep 17 00:00:00 2001 From: alihsaas <40891677+alihsaas@users.noreply.github.com> Date: Tue, 22 Jul 2025 22:10:03 +0300 Subject: [PATCH] fix effect typing not including cleanup as parameter for callback --- packages/charm/src/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/charm/src/index.d.ts b/packages/charm/src/index.d.ts index da1c5fa..8336177 100644 --- a/packages/charm/src/index.d.ts +++ b/packages/charm/src/index.d.ts @@ -86,7 +86,7 @@ declare namespace Charm { * @param callback The function to run. * @returns A function that unsubscribes the callback. */ - function effect(callback: () => Cleanup | void): Cleanup; + function effect(callback: (cleanup: Cleanup) => Cleanup | void): Cleanup; /** * Returns the result of the function without subscribing to changes. If a